move spring-jms-2.0 tests to java#11195
Merged
laurit merged 6 commits intoApr 29, 2024
Merged
Conversation
steverao
reviewed
Apr 22, 2024
| import org.springframework.context.annotation.AnnotationConfigApplicationContext; | ||
| import org.springframework.jms.core.JmsTemplate; | ||
|
|
||
| public class SpringListenerTest { |
Contributor
There was a problem hiding this comment.
Suggested change
| public class SpringListenerTest { | |
| class SpringListenerTest { |
| AtomicReference<SpanData> producerSpan = new AtomicReference<>(); | ||
| testing.waitAndAssertSortedTraces( | ||
| orderByRootSpanKind(PRODUCER, CONSUMER), | ||
| trace -> { |
Contributor
There was a problem hiding this comment.
Here and other places in this PR, you can extract a public method, and then simplify the code together with the following verification logic. Can refer to
Contributor
There was a problem hiding this comment.
I think that in the original groovy test the assertions were copied from some other test file. If needed you can move the assertions for produce/receive/process spans to helper methods and share these assertions between tests (if that makes sense), see https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/spring/spring-kafka-2.7/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/kafka/v2_7/SpringKafkaTest.java for ideas.
laurit
reviewed
Apr 22, 2024
237304c to
c5f791c
Compare
aschugunov
commented
Apr 24, 2024
laurit
reviewed
Apr 25, 2024
laurit
reviewed
Apr 25, 2024
laurit
reviewed
Apr 25, 2024
laurit
reviewed
Apr 25, 2024
laurit
reviewed
Apr 25, 2024
laurit
approved these changes
Apr 25, 2024
jeanbisutti
reviewed
Apr 25, 2024
| import org.springframework.jms.config.DefaultJmsListenerContainerFactory; | ||
| import org.springframework.jms.config.JmsListenerContainerFactory; | ||
|
|
||
| class AbstractConfig { |
Member
There was a problem hiding this comment.
Suggested change
| class AbstractConfig { | |
| abstract class AbstractConfig { |
steverao
approved these changes
Apr 26, 2024
jeanbisutti
approved these changes
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.