Skip to content

Convert couchbase client 3.1 from groovy to java#10880

Merged
laurit merged 10 commits into
open-telemetry:mainfrom
jaydeluca:couchbase-client-31
Mar 19, 2024
Merged

Convert couchbase client 3.1 from groovy to java#10880
laurit merged 10 commits into
open-telemetry:mainfrom
jaydeluca:couchbase-client-31

Conversation

@jaydeluca

Copy link
Copy Markdown
Member

Related to #7195

A few notes:

  • couchbase/server:6.5.1 containers won't run on M1 macs. I found a thread saying that 7.1.0+ should work, but I wasn't able to get any of the couchbase tests using containers to work locally using any versions available, but perhaps I'm doing something wrong.
  • I wasn't sure the best way to handle the partial name assertion for the spans (in my tests the resulting span names were cb.get and cb.dispatch_to_server), so I made an attempt but if there is a different way to be handling those, let me know and I will update.
  • This test is the flakiest test in the suite. I extended the cluster config to extend the timeout from 10 to 30 seconds, but I'm not sure if that will help or not.
image

@jaydeluca jaydeluca requested a review from a team March 17, 2024 12:30
@laurit

laurit commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

couchbase/server:6.5.1 containers won't run on M1 macs. I found a thread saying that 7.1.0+ should work, but I wasn't able to get any of the couchbase tests using containers to work locally using any versions available, but perhaps I'm doing something wrong.

I tried using couchbase/server:7.6.0 and it always timeouts unless I also change com.couchbase.client:java-client version to 3.1.4. Maybe that would also get it working on the M1?

  • This test is the flakiest test in the suite. I extended the cluster config to extend the timeout from 10 to 30 seconds, but I'm not sure if that will help or not.

I don't remember whether increasing the timeout to whatever it was before to 10 reduced the flakiness or not. Looking at the release notes https://docs.couchbase.com/java-sdk/current/project-docs/sdk-release-notes.html#version-3-1-4-7-april-2021 3.1.4 and 3.1.1 have fixes related to waitUntilReady. spring-projects/spring-data-couchbase#1070 hints that perhaps the waitUntilReady didn't work as expected before 3.1.4. I'd be ok to running the test agains 3.1.4 instead of 3.1.0 if this gets rid of the flakiness.

Comment thread instrumentation/couchbase/couchbase-3.1/javaagent/build.gradle.kts
Comment thread instrumentation/couchbase/couchbase-3.1/javaagent/build.gradle.kts Outdated
laurit added 2 commits March 19, 2024 15:24
…a/io/opentelemetry/javaagent/instrumentation/couchbase/v3_1/CouchbaseClient31Test.java
@laurit laurit merged commit e3f90d2 into open-telemetry:main Mar 19, 2024
@jaydeluca

Copy link
Copy Markdown
Member Author

Thanks for all of your help as usual @laurit ! I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants