Skip to content

Follow spec for http redirects #5722

@trask

Description

@trask

Currently http client instrumentation generates just one http client span to cover the initial request and any subsequent redirects:

span -> assertClientSpan(span, uri, method, responseCode).hasNoParent(),
span -> assertServerSpan(span).hasParent(trace.getSpan(0)),
span -> assertServerSpan(span).hasParent(trace.getSpan(0)));

span -> assertClientSpan(span, uri, method, responseCode).hasNoParent(),
span -> assertServerSpan(span).hasParent(trace.getSpan(0)),
span -> assertServerSpan(span).hasParent(trace.getSpan(0)),
span -> assertServerSpan(span).hasParent(trace.getSpan(0)));

The http semantic conventions now state:

A CLIENT span SHOULD be created for each one of these physical requests.
No span is created corresponding to the "logical" (encompassing) request.

We should see if there are various instrumentation points that would allow us to capture each physical requests, and at least document which instrumentations do not follow this convention for redirects.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions