Update jaeger example to export over OTLP#67
Merged
mateuszrzeszutek merged 1 commit intoNov 15, 2022
Conversation
Member
Author
|
cc @breedx-splk |
breedx-splk
approved these changes
Nov 14, 2022
breedx-splk
left a comment
Contributor
There was a problem hiding this comment.
Oh killer! Thanks for getting ahead of this. Much appreciated. 🙌🏻
Comment on lines
-44
to
+45
| .addSpanProcessor(SimpleSpanProcessor.create(jaegerExporter)) | ||
| .addSpanProcessor(BatchSpanProcessor.builder(jaegerOtlpExporter).build()) |
Contributor
There was a problem hiding this comment.
This feels like a good idea because most users want this...but it wasn't entirely necessary was it?
Member
Author
There was a problem hiding this comment.
No, not necessary! Updated because not good to have examples doing things we would advise against.
breedx-splk
approved these changes
Nov 14, 2022
mateuszrzeszutek
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jaeger supports OTLP, and there's an effort to deprecate the jaeger exporter, so it seems appropriate to demonstrate SDK w/ OTLP exporter to Jaeger backend.