Skip to content

Handle ContainerResource edge case#4518

Merged
jack-berg merged 3 commits into
open-telemetry:mainfrom
jack-berg:fix-container-resource
Jun 7, 2022
Merged

Handle ContainerResource edge case#4518
jack-berg merged 3 commits into
open-telemetry:mainfrom
jack-berg:fix-container-resource

Conversation

@jack-berg

Copy link
Copy Markdown
Member

Fixes #4507.

@jack-berg jack-berg requested a review from a user June 6, 2022 22:51
@jack-berg jack-berg requested a review from Oberon00 as a code owner June 6, 2022 22:51
@codecov

codecov Bot commented Jun 6, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4518 (08dbf6a) into main (7d80a99) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff            @@
##               main    #4518   +/-   ##
=========================================
  Coverage     90.03%   90.03%           
- Complexity     5051     5052    +1     
=========================================
  Files           580      580           
  Lines         15562    15565    +3     
  Branches       1494     1496    +2     
=========================================
+ Hits          14011    14014    +3     
  Misses         1090     1090           
  Partials        461      461           
Impacted Files Coverage Δ
...try/sdk/extension/resources/ContainerResource.java 81.08% <75.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d80a99...08dbf6a. Read the comment docs.

jack-berg and others added 2 commits June 7, 2022 09:53
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
@jack-berg jack-berg merged commit 29f274e into open-telemetry:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in the ContainerResource implementation on the Containerd runtime.

2 participants