LegacySpanProcessorInstrumentation has a bug in reporting the "processedSpans" metric #8142
Description
Describe the bug
LegacySpanProcessorInstrumentation.finishSpans() method has an inverted check for "no error" which prevents it from correctly reporting the "processedSpans" metric.
@Override
public void finishSpans(int count, @Nullable String error) {
// Legacy metrics only record when no error.
if (error != null) { // <--- **This is wrong. The if condition must be changed to: "error == null"**
processedSpans().add(count, standardAttrs);
}
}