Prototype for the advice api#4341
Closed
dashpole wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
Conversation
45e03f1 to
c65b194
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4341 +/- ##
=======================================
- Coverage 83.4% 83.3% -0.1%
=======================================
Files 185 185
Lines 14332 14354 +22
=======================================
+ Hits 11958 11971 +13
- Misses 2147 2156 +9
Partials 227 227
|
c65b194 to
9915c30
Compare
Contributor
|
LGTM. I've added this to the SIG meeting agenda for tomorrow so we can review and close the issue. |
Member
LGTM |
Contributor
|
Reviewed in the SIG, and we concluded this satisfies the PoC requirement. Closing. |
This was referenced Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This demonstrates that an option on histogram instruments for providing explicit bucket boundaries can be added in a backwards-compatible manner.
This prototype is missing:
Advicefield. But our Instrument struct is used by Views, and it seems incorrect to select on advice from a view.Prototype for #4162