GH workflows for PR build and Releases#64
Merged
cijothomas merged 2 commits intoopen-telemetry:mainfrom Feb 9, 2021
Merged
Conversation
eddynaka
approved these changes
Feb 7, 2021
Codecov Report
@@ Coverage Diff @@
## main #64 +/- ##
=======================================
Coverage 70.95% 70.95%
=======================================
Files 28 28
Lines 809 809
=======================================
Hits 574 574
Misses 235 235 |
cijothomas
reviewed
Feb 9, 2021
Contributor
Author
|
We should also remove the common pack and upload to myget workflow: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/.github/workflows/dotnet-core.yml |
cijothomas
approved these changes
Feb 9, 2021
This was referenced Feb 11, 2021
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Probably it's not the best approach to have a separate release workflow for each project because there's a lot of code duplication. But so far I couldn't find a way to reuse or include one common workflow into specific ones. Happy to discuss a better way to do this.