Fix generation of pkg-config file with absolute includedir/libdir.#1199
Fix generation of pkg-config file with absolute includedir/libdir.#1199dota17 merged 1 commit intoopen-source-parsers:masterfrom lopsided98:pkgconfig-paths
Conversation
|
LGTM. |
CMakeLists.txt
Outdated
| @@ -1,5 +1,7 @@ | |||
| # vim: et ts=4 sts=4 sw=4 tw=0 | |||
|
|
|||
| set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_CURRENT_SOURCE_DIR}/cmake") | |||
There was a problem hiding this comment.
Can this line move down a bit? I think there should be a better place.
There was a problem hiding this comment.
I moved it down. If you have somewhere specific you want it let me know.
|
Thanks. |
|
Related to this PR (but also just jsoncpp installation in general), note that work is underway to (hopefully) come up with a design for built-in pkg-config features for CMake's One major hurdle to overcome in the design so far has been the question of input dependency handling. Particularly in a presumptive future where CMake, when generating the build system for some project, may have to contend with dependencies that are defined by a mix of native CMake As a CMake project which also generates and installs |
The CMake variables
CMAKE_INSTALL_LIBDIRandCMAKE_INSTALL_INCLUDEDIRare not guaranteed to be relative paths. If they are absolute, an invalid pkg-config file is generated.See https://github.com/jtojnar/cmake-snips#concatenating-paths-when-building-pkg-config-files for more information.