Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: open-source-cooperative/keyring-rs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.6.2
Choose a base ref
...
head repository: open-source-cooperative/keyring-rs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.6.3
Choose a head ref
  • 15 commits
  • 6 files changed
  • 6 contributors

Commits on Jul 26, 2025

  1. Configuration menu
    Copy the full SHA
    2c0a659 View commit details
    Browse the repository at this point in the history
  2. revert from moving items

    kamou authored and brotskydotcom committed Jul 26, 2025
    Configuration menu
    Copy the full SHA
    596b2db View commit details
    Browse the repository at this point in the history
  3. Only unlock Item if locked

    kamou authored and brotskydotcom committed Jul 26, 2025
    Configuration menu
    Copy the full SHA
    2ab2617 View commit details
    Browse the repository at this point in the history
  4. Remove unnecessary lifetime indicator

    kamou authored and brotskydotcom committed Jul 26, 2025
    Configuration menu
    Copy the full SHA
    8142e3c View commit details
    Browse the repository at this point in the history
  5. Revert map_matching*_items updates

    kamou authored and brotskydotcom committed Jul 26, 2025
    Configuration menu
    Copy the full SHA
    8bf8e77 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    afcc314 View commit details
    Browse the repository at this point in the history
  7. Cosmetic fix: remove blank lines

    kamou authored and brotskydotcom committed Jul 26, 2025
    Configuration menu
    Copy the full SHA
    88a3d6c View commit details
    Browse the repository at this point in the history
  8. Revert variable renaming

    kamou authored and brotskydotcom committed Jul 26, 2025
    Configuration menu
    Copy the full SHA
    7b408ed View commit details
    Browse the repository at this point in the history
  9. windows: use static value for 'comment' attribute

    Some Windows environments have a severely restricted 256 characters
    allowed for a 'comment'. When the 'user' and 'service' attributes are
    lengthy (e.g., client IDs and URLs), this information can exceed the
    limit -- particularly in the 'target == None' case (where both 'user'
    and 'service' are duplicated).
    
    To add to the trouble, the call to `credential.validate_attributes()`
    before this function returns prevents a consumer from updating this
    comment to be within the length limit.
    
    Switch to a static string for this comment that is within any
    reasonable length limit. If a consumer would like to add their own
    more verbose comment, they can do so with `Entry::update_attributes()`
    after the entry is created.
    
    Note: a pass-through optional parameter for the comment value was
    considered, but there's not really a good, obvious answer for a clean
    API on Entry with such an approach. The 'comment' attribute also
    appears to be Windows-specific. This approach should not have any
    impact on consumers and certainly does not have an impact on the API.
    
    An alternate-alternate approach may be possible with just removing the
    call to `credential.validate_attributes()`, but I don't have the
    expertise to understand what the effects of this would be.
    vermiculus authored and brotskydotcom committed Jul 26, 2025
    Configuration menu
    Copy the full SHA
    46eebf5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    19ec928 View commit details
    Browse the repository at this point in the history
  11. Zero out credential passwords before dealloc.

    This fixes #251 on Windows.
    brotskydotcom committed Jul 26, 2025
    Configuration menu
    Copy the full SHA
    b9af61d View commit details
    Browse the repository at this point in the history
  12. Cherry pick all contributions since 3.6.2.

    This omits the change to LazyLock, which would update the MSRV.
    
    With this, we can release v3.6.3.
    brotskydotcom committed Jul 26, 2025
    Configuration menu
    Copy the full SHA
    f38b5e9 View commit details
    Browse the repository at this point in the history
  13. Update windows-sys requirement from 0.59 to 0.60

    Updates the requirements on [windows-sys](https://github.com/microsoft/windows-rs) to permit the latest version.
    - [Release notes](https://github.com/microsoft/windows-rs/releases)
    - [Commits](https://github.com/microsoft/windows-rs/commits)
    
    ---
    updated-dependencies:
    - dependency-name: windows-sys
      dependency-version: 0.60.2
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Jul 26, 2025
    Configuration menu
    Copy the full SHA
    a3470f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2025

  1. Merge pull request #260 from open-source-cooperative/dependabot/cargo…

    …/windows-sys-0.60
    
    Update windows-sys to v60.
    brotskydotcom authored Jul 27, 2025
    Configuration menu
    Copy the full SHA
    edee747 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    315cbdf View commit details
    Browse the repository at this point in the history
Loading