-
-
Notifications
You must be signed in to change notification settings - Fork 63
Comparing changes
Open a pull request
base repository: open-source-cooperative/keyring-rs
base: v3.6.2
head repository: open-source-cooperative/keyring-rs
compare: v3.6.3
- 15 commits
- 6 files changed
- 6 contributors
Commits on Jul 26, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 2c0a659 - Browse repository at this point
Copy the full SHA 2c0a659View commit details -
Configuration menu - View commit details
-
Copy full SHA for 596b2db - Browse repository at this point
Copy the full SHA 596b2dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ab2617 - Browse repository at this point
Copy the full SHA 2ab2617View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8142e3c - Browse repository at this point
Copy the full SHA 8142e3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bf8e77 - Browse repository at this point
Copy the full SHA 8bf8e77View commit details -
Configuration menu - View commit details
-
Copy full SHA for afcc314 - Browse repository at this point
Copy the full SHA afcc314View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88a3d6c - Browse repository at this point
Copy the full SHA 88a3d6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b408ed - Browse repository at this point
Copy the full SHA 7b408edView commit details -
windows: use static value for 'comment' attribute
Some Windows environments have a severely restricted 256 characters allowed for a 'comment'. When the 'user' and 'service' attributes are lengthy (e.g., client IDs and URLs), this information can exceed the limit -- particularly in the 'target == None' case (where both 'user' and 'service' are duplicated). To add to the trouble, the call to `credential.validate_attributes()` before this function returns prevents a consumer from updating this comment to be within the length limit. Switch to a static string for this comment that is within any reasonable length limit. If a consumer would like to add their own more verbose comment, they can do so with `Entry::update_attributes()` after the entry is created. Note: a pass-through optional parameter for the comment value was considered, but there's not really a good, obvious answer for a clean API on Entry with such an approach. The 'comment' attribute also appears to be Windows-specific. This approach should not have any impact on consumers and certainly does not have an impact on the API. An alternate-alternate approach may be possible with just removing the call to `credential.validate_attributes()`, but I don't have the expertise to understand what the effects of this would be.
Configuration menu - View commit details
-
Copy full SHA for 46eebf5 - Browse repository at this point
Copy the full SHA 46eebf5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19ec928 - Browse repository at this point
Copy the full SHA 19ec928View commit details -
Zero out credential passwords before dealloc.
This fixes #251 on Windows.
Configuration menu - View commit details
-
Copy full SHA for b9af61d - Browse repository at this point
Copy the full SHA b9af61dView commit details -
Cherry pick all contributions since 3.6.2.
This omits the change to LazyLock, which would update the MSRV. With this, we can release v3.6.3.
Configuration menu - View commit details
-
Copy full SHA for f38b5e9 - Browse repository at this point
Copy the full SHA f38b5e9View commit details -
Update windows-sys requirement from 0.59 to 0.60
Updates the requirements on [windows-sys](https://github.com/microsoft/windows-rs) to permit the latest version. - [Release notes](https://github.com/microsoft/windows-rs/releases) - [Commits](https://github.com/microsoft/windows-rs/commits) --- updated-dependencies: - dependency-name: windows-sys dependency-version: 0.60.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for a3470f1 - Browse repository at this point
Copy the full SHA a3470f1View commit details
Commits on Jul 27, 2025
-
Merge pull request #260 from open-source-cooperative/dependabot/cargo…
…/windows-sys-0.60 Update windows-sys to v60.
Configuration menu - View commit details
-
Copy full SHA for edee747 - Browse repository at this point
Copy the full SHA edee747View commit details -
Configuration menu - View commit details
-
Copy full SHA for 315cbdf - Browse repository at this point
Copy the full SHA 315cbdfView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.6.2...v3.6.3