Conversation
Member
Author
|
This could be resolved by point minimal_kex_oqs to use SIDH rather than NTRU because SIDH is available on Windows. |
Member
Author
|
I'll do this today, never mind @christianpaquin. |
Member
Author
|
@smashra Can you please review this? |
smashra
approved these changes
Sep 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we have fewer KEX algorithms left, minimal_kex_oqs has to be updated (and also becomes less necessary?). It is currently causing the Windows build to fail. @christianpaquin Do you think it's worth investigating, or should we just remove minimal_kex_oqs from the Windows build since all the KEXes will go away over the next month or so?