Merged
Conversation
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
26e76ad to
8e1663d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
- Coverage 57.16% 56.79% -0.38%
==========================================
Files 1 1
Lines 572 574 +2
==========================================
- Hits 327 326 -1
- Misses 181 183 +2
- Partials 64 65 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Nov 2, 2024
Merged
ritazh
requested changes
Nov 5, 2024
maxsmythe
approved these changes
Nov 5, 2024
Contributor
maxsmythe
left a comment
There was a problem hiding this comment.
LGTM after Rita's suggestion
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Contributor
Author
|
Applied the suggestion, nice catch! :) |
ritazh
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps k8s deps to v0.31.2. We use this pkg in KEDA, and we'd like to ship a release with updated k8s deps. Could you ship a release after merging the PR? 🙏
As k8s have introduced a new check to prevent multiple controller with the same name, this PR adds a field to customize the contoller name for unit tests. This is required because the controller is registered multiple times with different configurations