[Fix] Add max_keep_ckpts for groupfree3d#765
Merged
ZwwWayne merged 1 commit intoopen-mmlab:masterfrom Jul 20, 2021
Merged
Conversation
Collaborator
Author
Codecov Report
@@ Coverage Diff @@
## master #765 +/- ##
=======================================
Coverage 48.97% 48.97%
=======================================
Files 208 208
Lines 15852 15852
Branches 2532 2532
=======================================
Hits 7763 7763
Misses 7591 7591
Partials 498 498
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ZwwWayne
approved these changes
Jul 20, 2021
Contributor
Sorry for the late reply! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
The size of a most simple groupfree3d ckpt is around 170MB, and there are by default 400 ckpts saved in one run, which will take about 70GB space. There is a high chance of disk space/quota exceed, which will terminate training.
Modification
I added
max_keep_ckptsin groupfree3d configs.BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist