update get_indexes in mixup#6516
Closed
zhaoxin111 wants to merge 1 commit intoopen-mmlab:masterfrom
zhaoxin111:master
Closed
update get_indexes in mixup#6516zhaoxin111 wants to merge 1 commit intoopen-mmlab:masterfrom zhaoxin111:master
zhaoxin111 wants to merge 1 commit intoopen-mmlab:masterfrom
zhaoxin111:master
Conversation
Member
|
@zhaoxin111 Thanks for your contribution! At that time, I didn't want to read the IMG every time in the loop when designing, because it didn't need it. I think the PR you mentioned is more reasonable. Our plan is to merge this PR. |
Contributor
Author
OK, I will reopen th PR and fix it. |
Collaborator
|
Closed as it is continued in #6526 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When the parameter dataset in MultiImageMixDataset is ConcatDataset/RepeatDataset/ClassBalancedDataset and mixup is added in the pipeline, the get_indexes in mixup will crash since there are no get_ann_info in ConcatDataset/RepeatDataset/ClassBalancedDataset.
Modification
change gt_bboxes_i = dataset.get_ann_info(index)['bboxes']
to gt_bboxes_i = dataset[index]['gt_bboxes']
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist