Skip to content

add bn buffer sync in eval_hook#4582

Merged
ZwwWayne merged 3 commits intoopen-mmlab:masterfrom
jshilong:sync_bn_buffer
Feb 8, 2021
Merged

add bn buffer sync in eval_hook#4582
ZwwWayne merged 3 commits intoopen-mmlab:masterfrom
jshilong:sync_bn_buffer

Conversation

@jshilong
Copy link
Copy Markdown
Collaborator

@jshilong jshilong commented Feb 4, 2021

I modified the eval_hook.py to support broadcast the buffer of batch_norm in rank 0 to other ranks , so as to ensure that the test results in the log can be consistent with individual test results with the saved checkpoint.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 4, 2021

Codecov Report

Merging #4582 (2e8c73d) into master (3620bb7) will decrease coverage by 0.12%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4582      +/-   ##
==========================================
- Coverage   63.76%   63.63%   -0.13%     
==========================================
  Files         252      252              
  Lines       19244    19163      -81     
  Branches     3246     3249       +3     
==========================================
- Hits        12271    12195      -76     
+ Misses       6344     6337       -7     
- Partials      629      631       +2     
Flag Coverage Δ
unittests 63.59% <55.55%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/evaluation/eval_hooks.py 54.83% <55.55%> (+0.05%) ⬆️
mmdet/core/bbox/coder/base_bbox_coder.py 75.00% <0.00%> (-5.00%) ⬇️
mmdet/models/roi_heads/base_roi_head.py 76.31% <0.00%> (-3.69%) ⬇️
mmdet/models/detectors/base.py 52.80% <0.00%> (-2.51%) ⬇️
mmdet/models/detectors/htc.py 87.50% <0.00%> (-1.39%) ⬇️
mmdet/models/necks/pafpn.py 38.29% <0.00%> (-1.29%) ⬇️
mmdet/core/bbox/samplers/base_sampler.py 73.17% <0.00%> (-1.25%) ⬇️
mmdet/models/losses/gfocal_loss.py 45.28% <0.00%> (-1.02%) ⬇️
mmdet/models/dense_heads/base_dense_head.py 89.47% <0.00%> (-1.01%) ⬇️
mmdet/core/bbox/samplers/sampling_result.py 72.13% <0.00%> (-0.89%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3620bb7...2e8c73d. Read the comment docs.

@ZwwWayne
Copy link
Copy Markdown
Collaborator

ZwwWayne commented Feb 8, 2021

NAS-FPN has been benchmarked in this PR and achieves mAP 37.7 (37.9 is reported). The result seems to be acceptable so the PR is merged.

@ZwwWayne ZwwWayne merged commit a7ac0cc into open-mmlab:master Feb 8, 2021
@jshilong jshilong deleted the sync_bn_buffer branch June 1, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants