add bn buffer sync in eval_hook#4582
Merged
ZwwWayne merged 3 commits intoopen-mmlab:masterfrom Feb 8, 2021
Merged
Conversation
added 2 commits
February 4, 2021 16:32
ZwwWayne
reviewed
Feb 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #4582 +/- ##
==========================================
- Coverage 63.76% 63.63% -0.13%
==========================================
Files 252 252
Lines 19244 19163 -81
Branches 3246 3249 +3
==========================================
- Hits 12271 12195 -76
+ Misses 6344 6337 -7
- Partials 629 631 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ZwwWayne
approved these changes
Feb 5, 2021
Collaborator
|
NAS-FPN has been benchmarked in this PR and achieves mAP 37.7 (37.9 is reported). The result seems to be acceptable so the PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified the eval_hook.py to support broadcast the buffer of batch_norm in rank 0 to other ranks , so as to ensure that the test results in the log can be consistent with individual test results with the saved checkpoint.