Skip to content

[Feature] Add python3.9 in CI#1291

Merged
ZwwWayne merged 3 commits intoopen-mmlab:masterfrom
zhouzaida:add-python3.9-in-ci
Aug 27, 2021
Merged

[Feature] Add python3.9 in CI#1291
ZwwWayne merged 3 commits intoopen-mmlab:masterfrom
zhouzaida:add-python3.9-in-ci

Conversation

@zhouzaida
Copy link
Copy Markdown
Collaborator

@zhouzaida zhouzaida commented Aug 23, 2021 •
edited
Loading

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support python3.9

Modification

Add python3.9 in CI

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 23, 2021 •
edited
Loading

Codecov Report

Merging #1291 (d7b75e3) into master (8aab4f2) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1291      +/-   ##
==========================================
+ Coverage   68.23%   68.27%   +0.04%     
==========================================
  Files         160      161       +1     
  Lines       10722    10742      +20     
  Branches     1969     1972       +3     
==========================================
+ Hits         7316     7334      +18     
- Misses       3022     3023       +1     
- Partials      384      385       +1
Flag Coverage Δ
unittests 68.27% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/runner/builder.py 100.00% <0.00%> (ø)
mmcv/runner/__init__.py 100.00% <0.00%> (ø)
mmcv/runner/default_constructor.py 77.77% <0.00%> (ø)
mmcv/video/processing.py 77.41% <0.00%> (+0.37%) ⬆️
mmcv/runner/hooks/logger/pavi.py 71.42% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aab4f2...d7b75e3. Read the comment docs.

@zhouzaida zhouzaida requested a review from ZwwWayne August 24, 2021 11:36
@zhouzaida zhouzaida mentioned this pull request Aug 26, 2021
Closed
16 tasks
@mzr1996 mzr1996 mentioned this pull request Aug 26, 2021
Merged
6 tasks
@ZwwWayne ZwwWayne merged commit 5617ad7 into open-mmlab:master Aug 27, 2021
@zhouzaida zhouzaida deleted the add-python3.9-in-ci branch August 27, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZwwWayne ZwwWayne ZwwWayne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhouzaida @ZwwWayne