[Feature] Support ImageNet21k dataset.#461
Merged
mzr1996 merged 15 commits intoopen-mmlab:masterfrom Oct 28, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #461 +/- ##
==========================================
+ Coverage 78.94% 79.06% +0.12%
==========================================
Files 104 105 +1
Lines 5760 5832 +72
Branches 933 944 +11
==========================================
+ Hits 4547 4611 +64
- Misses 1089 1093 +4
- Partials 124 128 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mzr1996
requested changes
Oct 26, 2021
mzr1996
requested changes
Oct 28, 2021
mmcls/datasets/imagenet21k.py
Outdated
|
|
||
| def __init__(self, | ||
| data_prefix, | ||
| pipeline=[], |
Member
There was a problem hiding this comment.
In BaseDataset, the pipeline doesn't have a default value, why do we need a default value here?
Collaborator
Author
There was a problem hiding this comment.
After thinking about, it is better not to set a default value here.
6 tasks
mzr1996
pushed a commit
to mzr1996/mmpretrain
that referenced
this pull request
Nov 24, 2022
* add imagnet21k * Update unit test * update imaenet21k * use slots * use slots * rename Data_item to ImageInfo * add unit tests * Update unit tests * rm some print * update unit tests * fix lint * remove default value of pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
add imagnet21k dataset
Modification
add imagnet21k dataset
BC-breaking (Optional)
No
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: