Merged
Conversation
56d7e57 to
af5af04
Compare
Existing behavior of auto scanning LUNs is problematic for some deployments, particularly in cases where we are: - Accessing different LUNs from the same target on different machines and we don't want the other LUNs automatically exposed in other systems. - LUNs are constantly being created and removed from the target by another machine and we don't want our systems polluted by no longer available logical units, since default udev rules don't remove them automatically from the system once they have been added automatically. This is a little more problematic when working with multipaths as we end up with a lot of leftover device maps. This patch introduces a new configuration option at the session level called "scan", with "auto" and "manual" as acceptable values, that allows us to disable the autoscan in the following cases: - On iscsid start - On login - On AEN/AER messages reporting LUNs data has changed. For HW drivers all sessions will use the value defined in the configuration file. Default value for this new option is "auto" to maintain existing behavior.
af5af04 to
5e32aea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow disabling auto LUN scans
Existing behavior of auto scanning LUNs is problematic for some
deployments, particularly in cases where we are:
Accessing different LUNs from the same target on different machines
and we don't want the other LUNs automatically exposed in other
systems.
LUNs are constantly being created and removed from the target by
another machine and we don't want our systems polluted by no longer
available logical units, since default udev rules don't remove them
automatically from the system once they have been added automatically.
This is a little more problematic when working with multipaths as we end
up with a lot of leftover device maps.
This patch introduces a new configuration option at the session level
called "scan", with "auto" and "manual" as acceptable values, that
allows us to disable the autoscan in the following cases:
For HW drivers all sessions will use the value defined in the
configuration file.
Default value for this new option is "auto" to maintain existing
behavior.