fix: Broaden definition of hook data value types.#307
Merged
Conversation
Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
beeme1mr
approved these changes
Apr 18, 2025
Member
|
@kinyoklion please run |
Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Member
Author
Done. |
askpt
approved these changes
Apr 21, 2025
jonathannorris
approved these changes
Apr 24, 2025
nicklasl
approved these changes
Apr 24, 2025
lukas-reining
approved these changes
Apr 24, 2025
This was referenced Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Loosens the value definition for hook data.
In the example within the spec, and within the implementation in the dotnet-sdk, the intent was to allow any type of data. For example creating an open telemetry span in before, storing it hook data, and ending it in after.
Notes
Related to: open-feature/dotnet-sdk#387