Conversation
beeme1mr
approved these changes
Aug 29, 2024
0ae0cfb to
4319b54
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
4319b54 to
dd59837
Compare
nicklasl
approved these changes
Aug 30, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
lukas-reining
approved these changes
Sep 3, 2024
Member
lukas-reining
left a comment
There was a problem hiding this comment.
Looks good to me!
Left one question.
aepfli
approved these changes
Sep 4, 2024
askpt
approved these changes
Sep 4, 2024
Member
askpt
left a comment
There was a problem hiding this comment.
LGTM. I have a minor question. With this spec change, will the LogHook become part of the SDK and should it be moved to the SDK repo?
Member
Author
Yep! I've implemented one in Java now here: open-feature/java-sdk#1084 A |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in recent meetings, we've had complaints about this from multiple sources. This PR adds a stipulation that no logging is done by the SDK during flag evaluation. It also defines a very simple
logging hookconcept as an included utility. These should be very simple to write and will provide all the needed logging but give authors more control than built in log statements. It will also be a very nice intro to the hooks concept for users.Here's the Java implementation: open-feature/java-sdk#1084