refactor!: move api evaluation context methods to api module#164
Merged
Conversation
0b0e72d to
a8137e1
Compare
Codecov Report
@@ Coverage Diff @@
## main #164 +/- ##
==========================================
- Coverage 94.16% 94.15% -0.02%
==========================================
Files 25 24 -1
Lines 463 462 -1
==========================================
- Hits 436 435 -1
Misses 27 27
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
beeme1mr
approved these changes
Aug 31, 2023
Member
|
Looks good to me, thanks. I've updated the PR title so that the change log marks this as a breaking change. |
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
a8137e1 to
22c0b50
Compare
kikihakiem
pushed a commit
to ResalApps/openfeature-python-sdk
that referenced
this pull request
Aug 28, 2025
…ure#164) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the import path for evaluation context methods from:
To:
This brings it closer to what users would expect after reading the spec. We should do something similar with the api hooks methods.
I will submit a series of pull requests later to continue adapting the module structure and make it more Pythonic.