feat: in-memory provider for sdk testing#192
Merged
beeme1mr merged 10 commits intoopen-feature:mainfrom Jul 28, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #192 +/- ##
==========================================
- Coverage 78.99% 78.63% -0.36%
==========================================
Files 9 10 +1
Lines 1076 1203 +127
==========================================
+ Hits 850 946 +96
- Misses 204 230 +26
- Partials 22 27 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kavindu-Dodan
commented
Jul 12, 2023
Kavindu-Dodan
commented
Jul 12, 2023
0459d87 to
f9f4b29
Compare
toddbaert
reviewed
Jul 12, 2023
toddbaert
reviewed
Jul 12, 2023
toddbaert
reviewed
Jul 12, 2023
toddbaert
approved these changes
Jul 12, 2023
Member
toddbaert
left a comment
There was a problem hiding this comment.
This is very straightforward. It's pretty much convinced me we should do this everywhere.
RealAnna
approved these changes
Jul 14, 2023
beeme1mr
approved these changes
Jul 14, 2023
76d9b6c to
a8c2838
Compare
Member
|
Perhaps we should add the |
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
a8c2838 to
b2d2084
Compare
Contributor
Author
For this PR, coverage complaint is on newly added in-memory providers. Some of the error paths are not covered with tests but IMO these are not essential (ex:- testing errors for each flag type) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Is related to OFEP open-feature/ofep#71 and shows the feasibility of an in-memory provider
Features
[1] - open-feature/ofep#71
[2] - https://github.com/open-feature/go-sdk/pull/192/files#diff-1e56a5f9a72a9694aeb6f3510e8a2e02359c3cbdb9bd5c906219e30756d857efR181