Skip to content

docs: Move fractional evaluation pages to website#833

Closed
agardnerIT wants to merge 5 commits intoopen-feature:mainfrom
agardnerIT:docs/fractional-evaluation
Closed

docs: Move fractional evaluation pages to website#833
agardnerIT wants to merge 5 commits intoopen-feature:mainfrom
agardnerIT:docs/fractional-evaluation

Conversation

@agardnerIT
Copy link
Contributor

@agardnerIT agardnerIT commented Aug 14, 2023

This PR

  • Moves fractional evaluation information to website

@agardnerIT
docs: migrate fractional evaluation page
e07ab61 
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
@agardnerIT
point to canonical fractional eval page
9383630 
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
@agardnerIT agardnerIT requested a review from a team August 14, 2023 00:31
@netlify
Copy link

netlify bot commented Aug 14, 2023 •
edited
Loading

✅ Deploy Preview for polite-licorice-3db33c ready!

Name Link
🔨 Latest commit e5bc867
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/64ec11e23ccbd3000865571c
😎 Deploy Preview https://deploy-preview-833--polite-licorice-3db33c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@agardnerIT
docs: add trailing line
9da5820 
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
beeme1mr
beeme1mr requested changes Aug 16, 2023
View reviewed changes
@Kavindu-Dodan Kavindu-Dodan mentioned this pull request Aug 17, 2023
Merged
craigpastro
craigpastro reviewed Aug 21, 2023
View reviewed changes
agardnerIT and others added 2 commits August 28, 2023 13:12
@agardnerIT @beeme1mr
Update docs/configuration/fractional_evaluation.md
8c4d9d5 
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
@agardnerIT
address review feedback
e5bc867 
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
@beeme1mr
Copy link
Member

beeme1mr commented Aug 31, 2023

@toddbaert @craigpastro, now that we've released the updated fractional evaluation logic, could you please confirm these docs are accurate?

@toddbaert
Copy link
Member

toddbaert commented Aug 31, 2023 •
edited
Loading

@toddbaert @craigpastro, now that we've released the updated fractional evaluation logic, could you please confirm these docs are accurate?

They are not at all accurate because of the conflict. The "old" contents are being moved, and instead the "new" contents should be, I guess, but I'm not sure I fully understand the intent of the move itself; I haven't been keeping up with all of the doc changes here.

@craigpastro
Copy link
Member

craigpastro commented Aug 31, 2023

All examples and samples are still using the now deprecated fractionalEvaluation key. Should those be updated?

@toddbaert
Copy link
Member

toddbaert commented Aug 31, 2023

All examples and samples are still using the now deprecated fractionalEvaluation key. Should those be updated?

Ya, basically this "move" should be performed again with the updated content. I dont think any content needs to be changed.

@agardnerIT
Copy link
Contributor Author

agardnerIT commented Sep 7, 2023

Closing in favour of one larger, but easier to review PR: #825

@agardnerIT agardnerIT closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craigpastro craigpastro craigpastro left review comments

@beeme1mr beeme1mr beeme1mr requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agardnerIT @beeme1mr @toddbaert @craigpastro