chore: adding licenses to release archives and provide zip archive for windows#642
Merged
toddbaert merged 1 commit intoopen-feature:mainfrom May 8, 2023
Merged
Conversation
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #642 +/- ##
=======================================
Coverage 72.77% 72.77%
=======================================
Files 24 24
Lines 2384 2384
=======================================
Hits 1735 1735
Misses 583 583
Partials 66 66 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
toddbaert
reviewed
May 5, 2023
toddbaert
approved these changes
May 5, 2023
Member
toddbaert
left a comment
There was a problem hiding this comment.
@Kavindu-Dodan Thanks for doing this! This should give us confidence to wave fossa alerts about distributing the license.
beeme1mr
approved these changes
May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #581 & #639
Third-party license artifacts #581
This PR improved release builds to add
<module>-third-party-license.tar.gzto release artifacts. This artifact contains third-party licenses extracted using https://github.com/google/go-licenses.This is an attempt to credit our dependencies and be license compliant (ex:- retaining copyright notices) where possible.
Note that, the go-license tool emits error if it fails to identify licenses (ex:- for non-go codes/internal deps). This breaks the build (as it writes to stderr) and the workaround was to use
continue-on-error: true. Unfortunately, GH Actions do not provide any better alternative and refer [1] for ongoing discussions. Errors are accumulated to artifactmodule-license-errors.txtfor anyone's interest.Artefact archive format for Windows #639
PR further set
.ziparchiving for Windows (i386 & x86-64)How to test
An example build was tested and a sample release is available here [2]. Please see
license.tar.gz&licenseErrors.txtfor third party license content[1] - actions/runner#2347
[2] - https://github.com/Kavindu-Dodan/flag-test-ground/releases/tag/v0.1.7