chore: add instructions for windows and fix failing unit tests#632
Merged
toddbaert merged 12 commits intoopen-feature:mainfrom May 4, 2023
Merged
chore: add instructions for windows and fix failing unit tests#632toddbaert merged 12 commits intoopen-feature:mainfrom
toddbaert merged 12 commits intoopen-feature:mainfrom
Conversation
Signed-off-by: RealAnna <anna.reale@dynatrace.com> readme, add instructions for windows Signed-off-by: RealAnna <anna.reale@dynatrace.com> tests: fix file tests Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Codecov Report
@@ Coverage Diff @@
## main #632 +/- ##
==========================================
+ Coverage 72.39% 72.77% +0.37%
==========================================
Files 24 24
Lines 2384 2384
==========================================
+ Hits 1726 1735 +9
+ Misses 592 583 -9
Partials 66 66 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
thisthat
reviewed
Apr 27, 2023
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
toddbaert
reviewed
Apr 28, 2023
Member
toddbaert
left a comment
There was a problem hiding this comment.
LGTM but I agree with @Kavindu-Dodan 's suggestions.
thisthat
reviewed
May 3, 2023
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
toddbaert
approved these changes
May 4, 2023
Merged
toddbaert
pushed a commit
that referenced
this pull request
May 4, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.5.3</summary> ## [0.5.3](flagd/v0.5.2...flagd/v0.5.3) (2023-05-04) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.5.2 ([#613](#613)) ([218f435](218f435)) * **deps:** update module github.com/spf13/cobra to v1.7.0 ([#587](#587)) ([12b3477](12b3477)) ### ✨ New Features * Introduce connect traces ([#624](#624)) ([28bac6a](28bac6a)) </details> <details><summary>flagd-proxy: 0.2.3</summary> ## [0.2.3](flagd-proxy/v0.2.2...flagd-proxy/v0.2.3) (2023-05-04) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.5.2 ([#613](#613)) ([218f435](218f435)) * **deps:** update module github.com/spf13/cobra to v1.7.0 ([#587](#587)) ([12b3477](12b3477)) ### ✨ New Features * Introduce connect traces ([#624](#624)) ([28bac6a](28bac6a)) </details> <details><summary>core: 0.5.3</summary> ## [0.5.3](core/v0.5.2...core/v0.5.3) (2023-05-04) ### 🐛 Bug Fixes * **deps:** update module github.com/bufbuild/connect-go to v1.6.0 ([#585](#585)) ([8f2f467](8f2f467)) * **deps:** update module github.com/bufbuild/connect-go to v1.7.0 ([#625](#625)) ([1b24fc9](1b24fc9)) * **deps:** update module github.com/open-feature/open-feature-operator to v0.2.34 ([#604](#604)) ([3e6a84b](3e6a84b)) * **deps:** update module github.com/prometheus/client_golang to v1.15.0 ([#608](#608)) ([0597a8f](0597a8f)) * **deps:** update module github.com/rs/cors to v1.9.0 ([#609](#609)) ([97066c1](97066c1)) * **deps:** update module github.com/rs/xid to v1.5.0 ([#614](#614)) ([e3dfbc6](e3dfbc6)) * **deps:** update module golang.org/x/crypto to v0.8.0 ([#595](#595)) ([36016d7](36016d7)) ### ✨ New Features * Introduce connect traces ([#624](#624)) ([28bac6a](28bac6a)) ### 🧹 Chore * add instructions for windows and fix failing unit tests ([#632](#632)) ([6999d67](6999d67)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
#630
Notes
The learning from this pr were: