-
Notifications
You must be signed in to change notification settings - Fork 25
Change EventMetadata type #234
Copy link
Copy link
Closed
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededtype: breaking-changeChanges in exposed interfaces or behaviourChanges in exposed interfaces or behaviour
Milestone
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededtype: breaking-changeChanges in exposed interfaces or behaviourChanges in exposed interfaces or behaviour
FlagMetadataandEventMetadataare shaped the same in the SDK:I think for consistency, that means we should use the same type for these, which I guess would mean it should be a
Dictionary<string, object>()unless there's some way we can bring them in line with your new implementation in a non-breaking way... maybe with extension methods?Originally posted by @toddbaert in #223 (comment)