fix(cli): multi ctf repo race#965
Merged
matthiasbruns merged 9 commits intoOct 7, 2025
Merged
Conversation
4f5ebce to
e7f615f
Compare
#### What this does - Removes the internal CTF plugin implementation. - Updates the OCI plugin to handle both OCI and CTF repositories through a unified provider mechanism. - Adjusts `go.mod` to include required dependency updates. #### Why this is needed - Simplifies plugin management by unifying repository handling logic. - Reduces code duplication and improves maintainability by leveraging the shared provider implementation. #### Implications - Existing CTF plugin functionality is integrated into the updated OCI plugin. - Consumers relying on the standalone CTF plugin will need to adapt to the unified provider approach. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
#### What this does - Updates the `go.mod` file to reference newer versions of the CTF and OCI bindings. - Adjusts related dependencies to their latest versions (`configuration`, `repository`, etc.). - Modifies tests to align with the updated dependency behavior. #### Why this is needed - Resolves compatibility issues with the latest versions of CTF and OCI. - Keeps the CLI in sync with upstream improvements and bug fixes in dependency modules. #### Implications - The updated dependencies may require testing for potential regressions. - Consumers must ensure compatibility with the adjusted versions of the bindings and respective APIs. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
… does not contain version Signed-off-by: Fabian Burth <fabian.burth@sap.com>
… does not contain version Signed-off-by: Fabian Burth <fabian.burth@sap.com>
#### What this does - Removes the internal CTF plugin implementation. - Updates the OCI plugin to handle both OCI and CTF repositories through a unified provider mechanism. - Adjusts `go.mod` to include required dependency updates. #### Why this is needed - Simplifies plugin management by unifying repository handling logic. - Reduces code duplication and improves maintainability by leveraging the shared provider implementation. #### Implications - Existing CTF plugin functionality is integrated into the updated OCI plugin. - Consumers relying on the standalone CTF plugin will need to adapt to the unified provider approach. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
#### What this does - Updates the `go.mod` file to reference newer versions of the CTF and OCI bindings. - Adjusts related dependencies to their latest versions (`configuration`, `repository`, etc.). - Modifies tests to align with the updated dependency behavior. #### Why this is needed - Resolves compatibility issues with the latest versions of CTF and OCI. - Keeps the CLI in sync with upstream improvements and bug fixes in dependency modules. #### Implications - The updated dependencies may require testing for potential regressions. - Consumers must ensure compatibility with the adjusted versions of the bindings and respective APIs. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
8d9288b to
e25f5da
Compare
jakobmoellerdev
approved these changes
Oct 7, 2025
matthiasbruns
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR fixes is supposed to fix the race conditions occuring when multiple ctf instances operate on the same ctf archive. The actual fix is provided in #964 and #963. Here, a the archive instance and its lock are shared between multiple ctf repositories operating on the archive.
Which issue(s) this PR fixes
Contributes to open-component-model/ocm-project#564