feat: ADR for plugin registry#918
Merged
morri-son merged 14 commits intoOct 2, 2025
Merged
Conversation
38556cb to
1b1ac43
Compare
jakobmoellerdev
left a comment
Member
There was a problem hiding this comment.
concise, to the point, good idea. Concept is something i love but I dont buy yet that a registry is just one component version. Apart from that the concept is good to me. I would like to see more details on how you expose what the plugin provides (which contracts) in introspectable metadata so we can offer better indexing and searching in the future.
ikhandamirov
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me so far.
Contributor
|
Well written, easy to grasp. Looks good to me. |
fabianburth
previously approved these changes
Oct 1, 2025
Contributor
|
I think (at least initially), we can avoid introducing dedicated config types and built based on resolvers. Besides that, straight forward - I like it! |
piotrjanik
reviewed
Oct 1, 2025
matthiasbruns
left a comment
Contributor
There was a problem hiding this comment.
I think it totally makes sense to have less work on our side and use existing infrastructure that's been used by go etc long time now. Waiting for the final version for a full review.
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
8d90d22 to
bd66cb5
Compare
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
…ishing a plugin Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
matthiasbruns
previously approved these changes
Oct 2, 2025
morri-son
reviewed
Oct 2, 2025
morri-son
reviewed
Oct 2, 2025
morri-son
reviewed
Oct 2, 2025
morri-son
reviewed
Oct 2, 2025
morri-son
reviewed
Oct 2, 2025
Contributor
|
looks very good. Just made some comments wrt wording. |
Co-authored-by: Gerald Morrison <67469729+morri-son@users.noreply.github.com> Signed-off-by: Gergely Brautigam <skarlso777@gmail.com>
piotrjanik
reviewed
Oct 2, 2025
piotrjanik
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Small, minor comment about ensuring commands follow simple scheme.
morri-son
previously approved these changes
Oct 2, 2025
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
piotrjanik
approved these changes
Oct 2, 2025
morri-son
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Closes open-component-model/ocm-project#616
Which issue(s) this PR fixes