feat: component lister implementation for CTF#912
Merged
Conversation
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
28202cd to
8856fe6
Compare
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
jakobmoellerdev
left a comment
Member
There was a problem hiding this comment.
im missing an integration test with a real ctf here and some smaller nits but mostly LGTM
Co-authored-by: Jakob Möller <contact@jakob-moeller.com> Signed-off-by: ikhandamirov <108289993+ikhandamirov@users.noreply.github.com>
Co-authored-by: Jakob Möller <contact@jakob-moeller.com> Signed-off-by: ikhandamirov <108289993+ikhandamirov@users.noreply.github.com>
Contributor
Author
What would be the value? Do you think the "component-descriptors/" prefix could change? |
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
jakobmoellerdev
previously approved these changes
Sep 29, 2025
piotrjanik
reviewed
Sep 30, 2025
Skarlso
reviewed
Oct 1, 2025
Skarlso
reviewed
Oct 1, 2025
Skarlso
reviewed
Oct 1, 2025
Skarlso
reviewed
Oct 1, 2025
Skarlso
reviewed
Oct 1, 2025
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
jakobmoellerdev
approved these changes
Oct 2, 2025
Skarlso
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR provides component lister implementation for CTF archives.
This PR depends on #911 and on bump of the
bindings/go/repositorymodule.Which issue(s) this PR fixes
Contributes to open-component-model/ocm-project#673