feat: remove repo iterator#898
Conversation
4149e72 to
818e40e
Compare
5c3fe3d to
10049d2
Compare
10049d2 to
5d90824
Compare
fabianburth
left a comment
There was a problem hiding this comment.
I think we should probably also rename the whole concept from resolver to spec provider, WDYT?
would this lead to a new package since this one is called |
|
I will update the docs once the discussions are resolved |
I believe it would |
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
ab70523 to
5db716c
Compare
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
…m:matthiasbruns/open-component-model into feat/575_regex_glob_resolver_repository_2
|
To be honest, I'd really love to get rid of the whole This would also include a renaming of the corresponding config. |
Current Name: since its in the Repository package, we would not prepend Repository in front of the name. In the ticket, it was mentioned resolver. We use "ocm.software/open-component-model/bindings/go/configuration/resolvers/v1/matcher" in the SpecProvider/Resolver/WhatEver We use the resolver package in binding. So why cant we keep the name as is? We might also add more implementations of RepositorySpecProvider I would rather rename the interface to Otherwise feel free to rename what you think makes sense :D |
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
…m:matthiasbruns/open-component-model into feat/575_regex_glob_resolver_repository_2
|
When you began the issue, we didn't even have the repository spec provider interface. The original resolver concept is implemented completely different from the spec provider (as it implemented a component version repository). I also said that my suggestion would require to also go back and rename the configuration package. I'm just trying to keep the naming consistent across the library, as this makes searching through it much easier too as it grows. The interface providing component version repositories is called Happy to hear other peoples opinions too @Skarlso @jakobmoellerdev. Might be that I care about the naming too much here. |
|
I don't mind longer names as long as they make sense together with their packages names + the function name. That's how you call them right? oci |
|
@fabianburth can you just rename the things as you wish? I really don't mind anymore at this point :D |
|
closing in favor of #905 |
What this PR does / why we need it
Follow up on discussions in #844
Which issue(s) this PR fixes
Contributes open-component-model/ocm-project#575