fix(tests): improve resource reconciliation and cleanup logic#827
Merged
jakobmoellerdev merged 1 commit intoSep 8, 2025
Merged
Conversation
- Replaced duplicated cleanup steps in tests with `DeferCleanup` for consistent teardown. - Introduced `NamespaceForTest` function to streamline namespace creation in tests. - Removed unused methods `GetNamespaced` and `Get` from utilities. - Centralized default timeout configuration for Kubernetes operations. Before this, there could be side effects due to shared pointers between tests. this was now fixed Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
2b85d15 to
319711e
Compare
Skarlso
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
DeferCleanupfor consistent teardown.NamespaceForTestfunction to streamline namespace creation in tests.GetNamespacedandGetfrom utilities.Which issue(s) this PR fixes
Before this, there could be side effects due to shared pointers between tests. this was now fixed