Skip to content

feat(cli)!: ocm get cv --recursive#604

Merged
jakobmoellerdev merged 44 commits into
open-component-model:mainfrom
fabianburth:feat/get-recursive
Aug 27, 2025
Merged

feat(cli)!: ocm get cv --recursive#604
jakobmoellerdev merged 44 commits into
open-component-model:mainfrom
fabianburth:feat/get-recursive

Conversation

@fabianburth

@fabianburth fabianburth commented Aug 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

This PR introduces the --recursive option ocm get cv.

Notes for the Reviewers
--output=yaml and --output=json now always return a list - even if only a single element is found. This is because those formats are intended to be machine readable, and not having to distinct between list or single elements makes parsing easier.
That's also why I had to adjust the ctf/verify tasks yq statement.

TODO:

  • Discuss cli repository API.
  • Discuss whether whether we want to offer utility methods for getting resolvers from context and rendering components.

Which issue(s) this PR fixes

open-component-model/ocm-project#563

@github-actions github-actions Bot added kind/feature new feature, enhancement, improvement, extension size/m Medium labels Aug 21, 2025
@github-actions github-actions Bot added the size/l Large label Aug 22, 2025
@fabianburth fabianburth force-pushed the feat/get-recursive branch 6 times, most recently from d0b59a0 to 248b971 Compare August 26, 2025 13:46
@fabianburth fabianburth changed the title feat(cli): ocm get cv --recursive feat(cli)!: ocm get cv --recursive Aug 26, 2025
@github-actions github-actions Bot added the !BREAKING-CHANGE! Breaking change in API or ocm-cli or spec label Aug 26, 2025
@fabianburth fabianburth marked this pull request as ready for review August 26, 2025 14:20
@fabianburth fabianburth requested a review from a team as a code owner August 26, 2025 14:20
jakobmoellerdev
jakobmoellerdev reviewed Aug 26, 2025
View reviewed changes
Comment thread cli/cmd/get/component-version/cmd.go
Comment thread cli/cmd/get/component-version/cmd.go Outdated
Comment thread cli/cmd/get/component-version/cmd.go
Comment thread cli/internal/render/graph/list/serializer.go
Comment thread cli/internal/render/graph/list/serializer.go Outdated
Comment thread cli/internal/repository/ocm/repository.go Outdated
Comment thread cli/internal/repository/ocm/repository.go Outdated
Comment thread cli/internal/repository/ocm/repository.go Outdated
Comment thread cli/internal/repository/ocm/repository.go
Comment thread cli/cmd/cmd_test.go
@fabianburth
safe intermediary state
dc41b47 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: initial draft of recursive get command
3342d14 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: adapt to changes in traverse
38fda77 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: cleanup and fix several issues
5342792 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
store intermediate state
748bc36 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: initial fully fledged get cv --recursive implementation
5bd5fda 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
safe intermediate state
4a26496 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: refactor a bit
cd64a7f 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: linter issues
7edc9db 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: accidentally deleted defaulting
91bc902 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: nil pointer
562b289 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: nil pointer
c770f8a 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: using recursive execution even if set to 0
214563c 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: version ordering
afb99a8 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: version ordering
a293c2b 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: generate
1016084 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: rebase
cedd342 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: rebase
0912bbb 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: rebase
f7f8673 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: unit tests only work with auto-detected config
7f113a6 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: add tests
3c26387 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: tests
7523d92 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: linter and generate
9207e7f 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: typo
1715b03 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: generate
1869ed0 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: adjust to get always returning lists now
c83ced0 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: update to released dag version
6aa87f5 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: update integration module to released dag version
866bf8f 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: add no opt default value to the recursive flag
e96ea2b 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: remove redundant default static comment as this is automaticall…
85a9d5a 
…y added by cobra for enums

Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: list serializer comment
e7bb3e8 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: generate
cb4a1c0 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: sort after filtering
d113b56 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: remove unnecessary change
ebe578a 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: break up render components into multiple functions
27d760a 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: add issue to nolint comment for deprecated resolvers
4e3c3e8 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: add issue to nolint comment for deprecated resolvers
acb9bbd 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: add issue to render loop TODO
99c37e0 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: add issue to render loop TODO
fbbf816 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: add issue to render loop TODO
ac7b870 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: go mod tidy after rebase
bdc9744 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@jakobmoellerdev jakobmoellerdev merged commit 77607ae into open-component-model:main Aug 27, 2025
22 checks passed
@fabianburth fabianburth deleted the feat/get-recursive branch August 27, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakobmoellerdev jakobmoellerdev jakobmoellerdev approved these changes

Assignees

No one assigned

Labels

!BREAKING-CHANGE! Breaking change in API or ocm-cli or spec kind/feature new feature, enhancement, improvement, extension size/l Large size/m Medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabianburth @jakobmoellerdev