fix: run plugin download integration separately as a go module#581
Merged
jakobmoellerdev merged 8 commits intoAug 18, 2025
Conversation
On-behalf-of: gergely.brautigam@sap.com Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
fabianburth
previously approved these changes
Aug 18, 2025
fabianburth
left a comment
Contributor
There was a problem hiding this comment.
Please add a comment on why you are doing this to the PR or the issue description.
On-behalf-of: gergely.brautigam@sap.com Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
4289f25 to
c1a4186
Compare
jakobmoellerdev
left a comment
Member
There was a problem hiding this comment.
https://github.com/open-component-model/open-component-model/actions/runs/17036887973/job/48291360611?pr=581#step:6:54 I think the tests are skipped out
Contributor
Author
|
Yeah saw in the log... I'm working on it. :D |
On-behalf-of: gergely.brautigam@sap.com Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: gergely.brautigam@sap.com Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: gergely.brautigam@sap.com Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
f8324e7 to
4f62604
Compare
jakobmoellerdev
previously approved these changes
Aug 18, 2025
On-behalf-of: gergely.brautigam@sap.com Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: gergely.brautigam@sap.com Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
8e9f247 to
8d09c0f
Compare
jakobmoellerdev
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Fixes #579
In order to avoid bloating the go mod file and make sure that the tests aren't run as part of the normal unit test flow, we cordon it off into its own module and mark give it a special Task file.
Which issue(s) this PR fixes