feat(cli): add plugin shutdown timeout flag#569
Merged
jakobmoellerdev merged 4 commits intoAug 18, 2025
Merged
Conversation
- Introduced `--plugin-shutdown-timeout` flag to manage plugin termination. - Default timeout is set to 10 seconds. Forces plugins to shut down if not completed within the specified time. - Updated CLI commands and documentation to include the new flag. Rationale: This ensures plugins do not hang during shutdown, improving the CLI's reliability and user experience. Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
Skarlso
previously approved these changes
Aug 14, 2025
Signed-off-by: Jakob Möller <jakob.moeller@sap.com> # Conflicts: # cli/docs/reference/ocm.md # cli/docs/reference/ocm_add.md # cli/docs/reference/ocm_add_component-version.md # cli/docs/reference/ocm_completion.md # cli/docs/reference/ocm_completion_bash.md # cli/docs/reference/ocm_completion_fish.md # cli/docs/reference/ocm_completion_powershell.md # cli/docs/reference/ocm_completion_zsh.md # cli/docs/reference/ocm_download.md # cli/docs/reference/ocm_download_plugin.md # cli/docs/reference/ocm_download_resource.md # cli/docs/reference/ocm_generate.md # cli/docs/reference/ocm_generate_docs.md # cli/docs/reference/ocm_get.md # cli/docs/reference/ocm_get_component-version.md # cli/docs/reference/ocm_version.md
Skarlso
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
--plugin-shutdown-timeoutflag to manage plugin termination.Which issue(s) this PR fixes
Rationale: This ensures plugins do not hang during shutdown, improving the CLI's reliability and user experience.
part of the helm input binary test did with @Skarlso
part of open-component-model/ocm-project#490