Skip to content

feat(cli): add tree renderer#511

Merged
jakobmoellerdev merged 54 commits into
open-component-model:mainfrom
fabianburth:feat/tree-renderer
Aug 18, 2025
Merged

feat(cli): add tree renderer#511
jakobmoellerdev merged 54 commits into
open-component-model:mainfrom
fabianburth:feat/tree-renderer

Conversation

@fabianburth

@fabianburth fabianburth commented Aug 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

This PR introduces:

  • a render loop for live display on command line
  • a tree renderer for rendering a DAG with a single root as shown below
── A (completed)
   ├─ B (completed)
   │  ╰─ C (completed)
   ╰─ D (completed)

Which issue(s) this PR fixes

Contributes to open-component-model/ocm-project#564

@github-actions github-actions Bot added kind/feature new feature, enhancement, improvement, extension size/l Large labels Aug 6, 2025
@jakobmoellerdev jakobmoellerdev mentioned this pull request Aug 7, 2025
Closed
@github-actions github-actions Bot added the size/m Medium label Aug 14, 2025
jakobmoellerdev
jakobmoellerdev previously approved these changes Aug 14, 2025
View reviewed changes
Comment thread cli/go.mod Outdated
Comment thread cli/internal/graph/renderer/render.go Outdated
Comment thread cli/internal/graph/renderer/render.go Outdated
Comment thread cli/internal/graph/renderer/render.go Outdated
Comment thread cli/internal/graph/renderer/render.go Outdated
Comment thread cli/internal/graph/renderer/render.go Outdated
Comment thread cli/internal/graph/renderer/tree_renderer.go Outdated
Comment thread cli/internal/graph/renderer/utils.go Outdated
Comment thread cli/internal/graph/renderer/utils.go Outdated
Comment thread cli/internal/graph/renderer/render.go Outdated
@fabianburth fabianburth marked this pull request as ready for review August 15, 2025 12:15
@fabianburth fabianburth requested a review from a team as a code owner August 15, 2025 12:15
jakobmoellerdev
jakobmoellerdev reviewed Aug 16, 2025
View reviewed changes
Comment thread cli/internal/renderer/graph/tree/renderer.go Outdated
Comment thread cli/internal/renderer/graph/tree/renderer.go
Comment thread cli/internal/renderer/graph/utils.go Outdated
Comment thread cli/internal/renderer/graph/utils.go Outdated
Comment thread cli/internal/renderer/render.go Outdated
fabianburth and others added 18 commits August 18, 2025 15:25
@fabianburth
feat: add tree renderer
156726a 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: static render children once previous siblings are completed
d1eb6d3 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: refactor graph renderer
5756a76 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: refactor graph renderer to functions
5a95bf8 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: update tree renderer to support multiple roots and improve erro…
b94a57d 
…r handling

Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: revert accidental refactor changes to map test
f9454a8 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: remove component test
d1b97d3 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: adjust comment
e547220 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: split up code into multiple files
5924ee4 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: adjust package name to renamed directory
1d49ef0 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: refactor get neighbors sorted to improve readability
280986a 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: clean up code
d96d104 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
chore: update to updated dag
391b2f0 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@jakobmoellerdev @fabianburth
chore: simplify wait behavior on render loop
49ca49b 
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
@fabianburth
feat: refactor render functions to be independent of graph, refactor …
4018070 
…package structure and introduce options

Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: linter issues
de41349 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: remove tree filename prefix
fbd3002 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: update names and comments
c1e8784 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
fabianburth and others added 26 commits August 18, 2025 16:35
@fabianburth
feat: refactor graph renderer
6f0ca41 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: refactor graph renderer to functions
7d63bda 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: update tree renderer to support multiple roots and improve erro…
7bb90af 
…r handling

Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: revert accidental refactor changes to map test
b9b534d 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: remove component test
cb21f15 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: adjust comment
a5e0d13 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: split up code into multiple files
99c66e5 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: adjust package name to renamed directory
e907db0 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: refactor get neighbors sorted to improve readability
7c3de0f 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: clean up code
184ef0f 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
chore: update to updated dag
b2ba4d1 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@jakobmoellerdev @fabianburth
chore: simplify wait behavior on render loop
e56de82 
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
@fabianburth
feat: refactor render functions to be independent of graph, refactor …
434169c 
…package structure and introduce options

Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: linter issues
971d975 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: remove tree filename prefix
766ddd8 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: update names and comments
54671e5 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
feat: introduce vertex serializer interface as we agreed we want to a…
e4db826 
…void func fields

Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
chore: incorporate review
1743052 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
fix: resolve potential overflow
c987642 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
docs: add comment
4679e38 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
chore: move some more stuff around
0a914d6 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
chore: add more documentation
b1fe6e2 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
docs: remove accidental line
517fb63 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
docs: remove accidental line
75f7d77 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
Merge remote-tracking branch 'fabianburth/feat/tree-renderer' into fe…
b21c844 
…at/tree-renderer

# Conflicts:
#	cli/internal/renderer/graph/tree/renderer.go
@jakobmoellerdev
Merge branch 'main' into feat/tree-renderer
83b46a8
@jakobmoellerdev jakobmoellerdev enabled auto-merge (squash) August 18, 2025 14:57
@jakobmoellerdev jakobmoellerdev merged commit 6e3f4a5 into open-component-model:main Aug 18, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakobmoellerdev jakobmoellerdev jakobmoellerdev approved these changes

Assignees

No one assigned

Labels

kind/feature new feature, enhancement, improvement, extension size/l Large size/m Medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabianburth @jakobmoellerdev