Skip to content

feat: download plugins from a component version#473

Merged
jakobmoellerdev merged 10 commits into
open-component-model:mainfrom
Skarlso:download-plugin-from-component-version
Aug 7, 2025
Merged

feat: download plugins from a component version#473
jakobmoellerdev merged 10 commits into
open-component-model:mainfrom
Skarlso:download-plugin-from-component-version

Conversation

@Skarlso

@Skarlso Skarlso commented Jul 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Closes open-component-model/ocm-project#570

Output

❯ ./tmp/bin/ocm download plugin ghcr.io/open-component-model/ocm//ocm.software/plugins/ecrplugin:0.27.0 --resource-name demo --output ./tmp/ecrplugin --extra-identity os=linux,architecture=amd64
time=2025-07-30T09:07:08.084+02:00 level=INFO msg="Resolving credentials via repository" identity="hostname=ghcr.io,path=open-component-model/ocm,type=OCIRepository/v1" config=DockerConfig/v1(~/.docker/config.json)
time=2025-07-30T09:07:08.150+02:00 level=INFO msg="got credential" serverAddress=ghcr.io username=skarlso serverAddress=ghcr.io
time=2025-07-30T09:07:08.150+02:00 level=INFO msg="resolving descriptor" reference=ghcr.io/open-component-model/ocm/component-descriptors/ocm.software/plugins/ecrplugin:0.27.0
time=2025-07-30T09:07:08.672+02:00 level=INFO msg="fetching descriptor" descriptor.mediaType=application/vnd.oci.image.manifest.v1+json descriptor.digest=sha256:c7a5c78c00a2af09a7f55ac43b92e1714d8279815c30dfc97332d94a8cfd5f01 descriptor.size=1997
time=2025-07-30T09:07:10.081+02:00 level=INFO msg="using component version for resource version" version=0.27.0
time=2025-07-30T09:07:10.081+02:00 level=INFO msg="downloading plugin resource" name=demo version=0.27.0 type=ocmPlugin identity="architecture=amd64,name=demo,os=linux,version=0.27.0"
time=2025-07-30T09:07:10.081+02:00 level=INFO msg="resolving descriptor" reference=ghcr.io/open-component-model/ocm/component-descriptors/ocm.software/plugins/ecrplugin:0.27.0
time=2025-07-30T09:07:10.645+02:00 level=INFO msg="fetching descriptor" descriptor.mediaType=application/vnd.oci.image.manifest.v1+json descriptor.digest=sha256:c7a5c78c00a2af09a7f55ac43b92e1714d8279815c30dfc97332d94a8cfd5f01 descriptor.size=1997
time=2025-07-30T09:07:12.238+02:00 level=INFO msg="found artifact in descriptor" artifact="architecture=amd64,name=demo,os=linux,version=0.27.0"
time=2025-07-30T09:07:16.774+02:00 level=INFO msg="made plugin binary executable" path=./tmp/ecrplugin
time=2025-07-30T09:07:16.774+02:00 level=INFO msg="plugin binary downloaded successfully" output=./tmp/ecrplugin

@Skarlso Skarlso requested a review from a team as a code owner July 30, 2025 07:09
@github-actions github-actions Bot added kind/feature new feature, enhancement, improvement, extension size/m Medium labels Jul 30, 2025
@Skarlso Skarlso force-pushed the download-plugin-from-component-version branch 3 times, most recently from f90e391 to 459f44a Compare July 30, 2025 07:26
@Skarlso Skarlso marked this pull request as draft July 30, 2025 07:26
@Skarlso Skarlso force-pushed the download-plugin-from-component-version branch from 459f44a to e6ee164 Compare July 30, 2025 07:28
@Skarlso Skarlso force-pushed the download-plugin-from-component-version branch from e6ee164 to 62c6dc9 Compare August 6, 2025 12:15
@github-actions github-actions Bot added the size/l Large label Aug 6, 2025
@Skarlso Skarlso force-pushed the download-plugin-from-component-version branch 5 times, most recently from d9c3f0d to 6d63d23 Compare August 6, 2025 15:36
@Skarlso Skarlso marked this pull request as ready for review August 6, 2025 15:58
jakobmoellerdev
jakobmoellerdev reviewed Aug 6, 2025
View reviewed changes

@jakobmoellerdev jakobmoellerdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, great stuff already!

Comment thread cli/cmd/download/plugin/cmd.go
Comment thread cli/cmd/download/plugin/cmd.go
Comment thread cli/cmd/download/plugin/cmd.go
Skarlso added 4 commits August 7, 2025 13:06
@Skarlso
feat: download plugins from a component version
674877b 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

On-behalf-of: @SAP gergely.brautigam@sap.com
@Skarlso
add a check to see if the downloaded plugin is a valid plugin
504a66a 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
add test and add verification for downloaded plugins
81931a2 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

On-behalf-of: gergely.brautigam@sap.com
@Skarlso
pulled together some of the code
fe8820e 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso force-pushed the download-plugin-from-component-version branch from d2e2ad5 to fe8820e Compare August 7, 2025 11:06
@Skarlso
removed extra SetupRepository because it is just one function call
1ceb897 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso force-pushed the download-plugin-from-component-version branch from ee1f417 to 1ceb897 Compare August 7, 2025 11:55
Skarlso added 4 commits August 7, 2025 14:11
@Skarlso
add defaulting for os and architecture
e5453c4 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
progress on table output
ee84f94 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
added output formatting
983ea26 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
fixed linter issues
a536920 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso force-pushed the download-plugin-from-component-version branch from 6803085 to a536920 Compare August 7, 2025 13:15
jakobmoellerdev
jakobmoellerdev previously approved these changes Aug 7, 2025
View reviewed changes
Comment thread cli/cmd/download/plugin/cmd.go Outdated
@Skarlso Skarlso force-pushed the download-plugin-from-component-version branch from 0f8f50a to 4b403e4 Compare August 7, 2025 13:30
@Skarlso Skarlso requested a review from jakobmoellerdev August 7, 2025 14:22
@jakobmoellerdev jakobmoellerdev merged commit e8080b6 into open-component-model:main Aug 7, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakobmoellerdev jakobmoellerdev jakobmoellerdev approved these changes

Assignees

No one assigned

Labels

kind/feature new feature, enhancement, improvement, extension size/l Large size/m Medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add download plugin to the ocm cli

2 participants

@Skarlso @jakobmoellerdev