chore(docs): ocm resource download ADR#364
Merged
jakobmoellerdev merged 8 commits intoJul 11, 2025
Merged
Conversation
cad50e9 to
38e4462
Compare
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
38e4462 to
2a506e1
Compare
# Conflicts: # .github/config/wordlist.txt
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
Skarlso
reviewed
Jul 9, 2025
Skarlso
reviewed
Jul 9, 2025
Skarlso
reviewed
Jul 9, 2025
Skarlso
reviewed
Jul 9, 2025
Skarlso
left a comment
Contributor
There was a problem hiding this comment.
Done with two comments left. :) 👍
# Conflicts: # .github/config/wordlist.txt
This makes it so that the OCI library can now dynamically discover top level artifacts in OCI layouts passed to upload scenarios. This is achieved by building a successor graph dynamically based on the index. The call itself is implemented to be extremely efficient for 90% of our cases. (1-10 main artifacts with <100 references). This effectively allows us to use layouts without passing in a source access and we can simplify our OCI repository interfaces signficantly. This means we are now much closer to the old OCMv1 Main Artifact Fetching in Artifact Sets. Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
ikhandamirov
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. If my comments regarding the name of the flag don't resonate, feel free to just resolve.
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
Skarlso
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Enable easy and simple interpretation of downloaded resources fetched from component versions based on a new set of specifications that integrates seamlessly with the new OCM Plugin System, while providing a rearchitected foundation from the OCM v1 download handlers.
Which issue(s) this PR fixes
fix open-component-model/ocm-project#545