Skip to content

chore(fix): prevent renovate from using the canonical version for bindings go module versions#2670

Merged
Skarlso merged 7 commits into
open-component-model:mainfrom
Skarlso:fix-renovate-rc-tag
May 29, 2026
Merged

chore(fix): prevent renovate from using the canonical version for bindings go module versions#2670
Skarlso merged 7 commits into
open-component-model:mainfrom
Skarlso:fix-renovate-rc-tag

Conversation

@Skarlso

@Skarlso Skarlso commented May 28, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

So this was a bit more involved actually... :D

Renovate created this pr: #2664

The solution in the end is to tell renovate to NOT use the canonical tag as a tag for the submodules.

Which issue(s) this PR fixes

Testing

How to test the changes
Verification
  • I have added/updated tests for my changes (see Test Requirements)
  • Tests pass locally (task test and task test/integration if applicable)
  • If touching multiple modules, go work is enabled (see go.work)
  • My changes do not decrease test coverage
  • I have tested the changes locally by running ocm

@Skarlso Skarlso requested a review from a team as a code owner May 28, 2026 10:56
@netlify

netlify Bot commented May 28, 2026

Copy link
Copy Markdown

Deploy Preview for ocm-website ready!

Name Link
🔨 Latest commit e25bcc1
🔍 Latest deploy log https://app.netlify.com/projects/ocm-website/deploys/6a193d4c23bdfb0008387c58
😎 Deploy Preview https://deploy-preview-2670--ocm-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added kind/chore chore, maintenance, etc. size/xs Extra small labels May 28, 2026
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6426b10f-a203-4bb0-b732-e638e1a33dcc

📥 Commits

Reviewing files that changed from the base of the PR and between 1f8b602 and 329d97b.

📒 Files selected for processing (1)
  • .github/renovate.json5
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/renovate.json5

📝 Walkthrough

Walkthrough

Renovate packageRules for ocm.software/open-component-model/** (gomod) now restrict matching to v0.0.0- prerelease patterns via matchCurrentValue and allowedVersions; prior schedule and minimumReleaseAge settings were removed.

Changes

Renovate OCM update configuration

Layer / File(s) Summary
OCM version-specific update rule
.github/renovate.json5
The packageRules entry for ocm.software/open-component-model/** now matches current values starting with v0.0.0- using matchCurrentValue and limits allowedVersions to ^v0\.0\.; scheduling and minimumReleaseAge fields were removed while enabled: false is preserved.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • jakobmoellerdev

Suggested labels

size/xs

Poem

🐰 I hopped through rules with nimble feet,
v0.0.0- now snug and neat,
Renovate reads the modest line,
Skipping updates, all fine and fine,
A carrot-coded config treat.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating Renovate configuration to prevent using canonical version tags for bindings Go module versions.
Description check ✅ Passed The description is related to the changeset, explaining why the Renovate configuration was updated and referencing the original problem (PR #2664).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the component/github-actions Changes on GitHub Actions or within `.github/` directory label May 28, 2026
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Actionable comments posted: 0

@jakobmoellerdev

Copy link
Copy Markdown
Member

This will effectively break all monorepo updates. How would you expect that no bumps are the correct expected behavior?

@Skarlso

Skarlso commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

This will effectively break all monorepo updates. How would you expect that no bumps are the correct expected behavior?

I don't think it will. 🤔

@Skarlso

Skarlso commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

Ah, I see. We did have proper sha updates.

@Skarlso

Skarlso commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

Ahhh I see. I think my first instinct will be right after all. Let me update this.

… version

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso force-pushed the fix-renovate-rc-tag branch from a58ecbf to fb77261 Compare May 28, 2026 11:28
@github-actions github-actions Bot added size/s Small and removed size/xs Extra small labels May 28, 2026
piotrjanik
piotrjanik previously approved these changes May 28, 2026
@piotrjanik piotrjanik self-requested a review May 28, 2026 11:36
@Skarlso

Skarlso commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

Mmmm.... my test still returns the canonical tag... hold on here.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/renovate.json5:
- Around line 182-187: The Renovate rule for the gomod package pattern
(ocm.software/open-component-model/**) currently uses matchCurrentValue:
'/^v0\\.0\\.0-/' but restricts disabling to only matchUpdateTypes:
['major','minor','patch']; remove the matchUpdateTypes entry (or replace it with
the complete list you intend to block) so the v0.0.0-* pseudo-version rule
applies to all update types; update the rule where matchCurrentValue and
matchUpdateTypes appear in the .github/renovate.json5 config accordingly and run
a Renovate dry-run to confirm v0.0.0-* deps are no longer updated for any
updateType.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b52aedfd-3e53-40dc-95ec-39fa7a719eb2

📥 Commits

Reviewing files that changed from the base of the PR and between a58ecbf and 0ad6b5f.

📒 Files selected for processing (1)
  • .github/renovate.json5

Comment thread .github/renovate.json5 Outdated
Skarlso added 2 commits May 28, 2026 13:57
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Actionable comments posted: 0

@Skarlso Skarlso changed the title chore(fix): remove the usage of direct resolution for renovate chore(fix): prevent renovate from using the canonical version for bindings go module versions May 28, 2026
Comment thread .github/renovate.json5 Outdated
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Comment thread .github/renovate.json5

@frewilhelm frewilhelm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but i would really love a comment explaining what is happening, so we do not have to wonder in the future

@Skarlso

Skarlso commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

@frewilhelm I'll add one in my next pr dealing with the release flow. :) Don't want to dismiss the 👍 s :D

@Skarlso Skarlso merged commit 4d9d16d into open-component-model:main May 29, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/github-actions Changes on GitHub Actions or within `.github/` directory kind/chore chore, maintenance, etc. size/s Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants