chore(fix): prevent renovate from using the canonical version for bindings go module versions#2670
Conversation
✅ Deploy Preview for ocm-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRenovate ChangesRenovate OCM update configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Actionable comments posted: 0 |
|
This will effectively break all monorepo updates. How would you expect that no bumps are the correct expected behavior? |
I don't think it will. 🤔 |
|
Ah, I see. We did have proper sha updates. |
|
Ahhh I see. I think my first instinct will be right after all. Let me update this. |
… version On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
a58ecbf to
fb77261
Compare
|
Mmmm.... my test still returns the canonical tag... hold on here. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/renovate.json5:
- Around line 182-187: The Renovate rule for the gomod package pattern
(ocm.software/open-component-model/**) currently uses matchCurrentValue:
'/^v0\\.0\\.0-/' but restricts disabling to only matchUpdateTypes:
['major','minor','patch']; remove the matchUpdateTypes entry (or replace it with
the complete list you intend to block) so the v0.0.0-* pseudo-version rule
applies to all update types; update the rule where matchCurrentValue and
matchUpdateTypes appear in the .github/renovate.json5 config accordingly and run
a Renovate dry-run to confirm v0.0.0-* deps are no longer updated for any
updateType.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b52aedfd-3e53-40dc-95ec-39fa7a719eb2
📒 Files selected for processing (1)
.github/renovate.json5
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
…nt-model into fix-renovate-rc-tag
|
Actionable comments posted: 0 |
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
frewilhelm
left a comment
There was a problem hiding this comment.
lgtm, but i would really love a comment explaining what is happening, so we do not have to wonder in the future
|
@frewilhelm I'll add one in my next pr dealing with the release flow. :) Don't want to dismiss the 👍 s :D |
What this PR does / why we need it
So this was a bit more involved actually... :D
Renovate created this pr: #2664
The solution in the end is to tell renovate to NOT use the canonical tag as a tag for the submodules.
Which issue(s) this PR fixes
Testing
How to test the changes
Verification
task testandtask test/integrationif applicable)go workis enabled (seego.work)ocm