Skip to content

fix(ci): stop sigstore integration tests running on every PR#2609

Merged
morri-son merged 4 commits into
open-component-model:mainfrom
jakobmoellerdev:fix/ci-integration-test-matrix-runner
May 22, 2026
Merged

fix(ci): stop sigstore integration tests running on every PR#2609
morri-son merged 4 commits into
open-component-model:mainfrom
jakobmoellerdev:fix/ci-integration-test-matrix-runner

Conversation

@jakobmoellerdev

Copy link
Copy Markdown
Member

Summary

  • The run_integration_tests matrix had a static include entry for bindings/go/sigstore/integration, which GitHub Actions injects unconditionally — even when the module is absent from the dynamic integration_test_modules_json list. This caused sigstore integration tests to run on every single PR.
  • Replace the matrix runner axis + exclude/include with a single module axis. Runner selection uses a top-level INTEGRATION_TEST_RUNNER_MAP env var (JSON object) looked up via fromJSON at job dispatch time, falling back to ubuntu-24.04-arm.
  • The map is static, defined at the top of the file with a comment pointing to the job, and documented with instructions for adding further overrides.

Test plan

  • Open a PR touching only bindings/go/sigstore/ (non-integration code) — sigstore integration tests should NOT appear in the matrix
  • Open a PR touching bindings/go/sigstore/integration/ — sigstore integration tests SHOULD run on ubuntu-latest
  • Open a PR touching .github/workflows/ci.yml — all tests run (CI changed path)
  • Verify other integration test modules still run on ubuntu-24.04-arm

@jakobmoellerdev jakobmoellerdev requested a review from a team as a code owner May 22, 2026 05:51
@netlify

netlify Bot commented May 22, 2026

Copy link
Copy Markdown

Deploy Preview for ocm-website ready!

Name Link
🔨 Latest commit c3ba39d
🔍 Latest deploy log https://app.netlify.com/projects/ocm-website/deploys/6a10103b40fe2f00088d1502
😎 Deploy Preview https://deploy-preview-2609--ocm-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the kind/bugfix Bug label May 22, 2026
@coderabbitai

coderabbitai Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@jakobmoellerdev has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 15 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: faeb61e8-e4c2-4b96-96ac-2bd46780581a

📥 Commits

Reviewing files that changed from the base of the PR and between f3a6699 and c3ba39d.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size/s Small component/github-actions Changes on GitHub Actions or within `.github/` directory labels May 22, 2026
The run_integration_tests matrix used a static `include` entry for
bindings/go/sigstore/integration, which GitHub Actions injects
unconditionally — even when the module is absent from the dynamic
integration_test_modules_json list. This caused sigstore integration
tests to run on every single PR regardless of what changed.

Replace the matrix runner axis + exclude/include with a single module
axis. Runner selection uses a top-level INTEGRATION_TEST_RUNNER_MAP
env var (JSON object) looked up via fromJSON at job dispatch time,
falling back to ubuntu-24.04-arm. The map is static and defined close
to the job with instructions for adding further overrides.

On-behalf-of: @SAP <jakob.moeller@sap.com>
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
On-behalf-of: @SAP <jakob.moeller@sap.com>
@jakobmoellerdev jakobmoellerdev force-pushed the fix/ci-integration-test-matrix-runner branch from 8928f29 to e0a9ea5 Compare May 22, 2026 05:52
fabianburth
fabianburth previously approved these changes May 22, 2026
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
On-behalf-of: @SAP <jakob.moeller@sap.com>
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
On-behalf-of: @SAP <jakob.moeller@sap.com>
@morri-son morri-son enabled auto-merge (squash) May 22, 2026 07:24
@morri-son morri-son merged commit f32f7d2 into open-component-model:main May 22, 2026
153 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/github-actions Changes on GitHub Actions or within `.github/` directory kind/bugfix Bug size/s Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants