Skip to content

fix: update constructor to use credentials.Resolver.Resolve (credentials v0.0.12 compat)#2603

Merged
jakobmoellerdev merged 1 commit into
open-component-model:mainfrom
jakobmoellerdev:fix/constructor-credentials-v0.0.12-compat
May 21, 2026
Merged

fix: update constructor to use credentials.Resolver.Resolve (credentials v0.0.12 compat)#2603
jakobmoellerdev merged 1 commit into
open-component-model:mainfrom
jakobmoellerdev:fix/constructor-credentials-v0.0.12-compat

Conversation

@jakobmoellerdev

@jakobmoellerdev jakobmoellerdev commented May 21, 2026

Copy link
Copy Markdown
Member

Summary

  • credentials v0.0.12 unified the Resolver interface to a single Resolve(ctx, identity) (runtime.Typed, error) method, removing the separate ResolveTyped method that existed in v0.0.11
  • constructor v0.0.8 (released as part of gate 4, PR feat!: migrate constructor binding to runtime.Typed credentials #2598) still calls provider.ResolveTyped and depends on credentials v0.0.11
  • This causes a build failure when any module depends on both constructor v0.0.8 and credentials v0.0.12

This fix updates construct.go to call provider.Resolve and bumps the credentials dependency to v0.0.12.

Dependency on

Must be released as constructor/v0.0.9 before PR #2602 (gate 5 plugin migration) can drop its replace directive.

@jakobmoellerdev jakobmoellerdev requested a review from a team as a code owner May 21, 2026 16:32
@coderabbitai

coderabbitai Bot commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@jakobmoellerdev has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 52 minutes and 8 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d1f36763-d258-448f-96e7-12da2755f5ff

📥 Commits

Reviewing files that changed from the base of the PR and between 2f5bcd0 and b49118b.

⛔ Files ignored due to path filters (1)
  • bindings/go/constructor/go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • bindings/go/constructor/construct.go
  • bindings/go/constructor/construct_resource_test.go
  • bindings/go/constructor/go.mod
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the kind/bugfix Bug label May 21, 2026
@netlify

netlify Bot commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for ocm-website canceled.

Name Link
🔨 Latest commit b49118b
🔍 Latest deploy log https://app.netlify.com/projects/ocm-website/deploys/6a0f33ccf5a11a0008fc2594

@github-actions github-actions Bot added the size/s Small label May 21, 2026
@jakobmoellerdev
fix: update constructor to use credentials.Resolver.Resolve (credenti…
b49118b 
…als v0.0.12 compat)

credentials v0.0.12 unified the Resolver interface to a single Resolve method
returning runtime.Typed, removing the separate ResolveTyped method from v0.0.11.

Update construct.go to call provider.Resolve instead of provider.ResolveTyped,
and bump the credentials dependency to v0.0.12.

On-behalf-of: @SAP <jakob.moeller@sap.com>
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
On-behalf-of: @SAP <jakob.moeller@sap.com>
@jakobmoellerdev jakobmoellerdev force-pushed the fix/constructor-credentials-v0.0.12-compat branch from dbd2c11 to b49118b Compare May 21, 2026 16:33
@jakobmoellerdev jakobmoellerdev merged commit e51f868 into open-component-model:main May 21, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frewilhelm frewilhelm frewilhelm approved these changes

Assignees

No one assigned

Labels

kind/bugfix Bug size/s Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakobmoellerdev @frewilhelm