feat: introduce file / path flag#242
Merged
jakobmoellerdev merged 2 commits intoJun 13, 2025
Merged
Conversation
b6774c8 to
0dc5062
Compare
this refactors the flag implementations and adds a flag type for file paths so that it is easy to pass file / directory references via flag. this flag automatically stats the path and collects underlying filesystem information.
0dc5062 to
45e0d58
Compare
Skarlso
reviewed
Jun 13, 2025
Skarlso
left a comment
Contributor
There was a problem hiding this comment.
Looks okay, just questions.. :)
dea5c13 to
e37fed3
Compare
Skarlso
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
this refactors the flag implementations and adds a flag type for file paths so that it is easy to pass file / directory references via flag. this flag automatically stats the path and collects underlying filesystem information.
Which issue(s) this PR fixes
This prepares for various commands such as
add cvwhich need to work with files / filesystems on a regular basis and could reuse a flag implementation that does the heavy lifting for them