Skip to content

fix(deps): Fix update module ocm.software/open-component-model/bindings/go/credentials to v0.0.10 (#2331)#2410

Merged
matthiasbruns merged 6 commits into
open-component-model:mainfrom
frewilhelm:fix-2331-3
Apr 29, 2026
Merged

fix(deps): Fix update module ocm.software/open-component-model/bindings/go/credentials to v0.0.10 (#2331)#2410
matthiasbruns merged 6 commits into
open-component-model:mainfrom
frewilhelm:fix-2331-3

Conversation

@frewilhelm

@frewilhelm frewilhelm commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Fixes test and lint failures caused by bumping bindings/go/credentials from v0.0.9 to v0.0.10 (#2331).

The v0.0.10 release added ResolveTyped to the credentials.Resolver interface and changed the default config type serialization to include the version suffix (credentials.config.ocm.software/v1).

Changes:

  • Add ResolveTyped to test mock implementations that directly implement credentials.Resolver (constructor, OCI transformer)
  • Add //nolint:staticcheck directives to deprecated Resolve calls that still need map[string]string until the full typed credentials migration is complete
  • Update Kubernetes controller test expectations to match the new versioned config type serialization

Which issue(s) this PR fixes

Fixes #2331

Related epic: open-component-model/ocm-project#702

Testing

task test
task test/integration

ocmbot Bot and others added 4 commits April 29, 2026 09:52
@ocmbot
fix(deps): update module ocm.software/open-component-model/bindings/g…
18ad43a 
…o/credentials to v0.0.10
@frewilhelm
add mock method
9819abb 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
disable linter for deprecation
5f4956d 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
adjust credential type in test
1454855 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm frewilhelm requested a review from a team as a code owner April 29, 2026 12:58
@netlify

netlify Bot commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for ocm-website ready!

Name Link
🔨 Latest commit 5ac20ee
🔍 Latest deploy log https://app.netlify.com/projects/ocm-website/deploys/69f206eeedc1f600080d89b5
😎 Deploy Preview https://deploy-preview-2410--ocm-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@frewilhelm has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 33 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9ba568f5-81b5-481e-918a-c2a59d0ae4af

📥 Commits

Reviewing files that changed from the base of the PR and between 0a4b4c3 and 5ac20ee.

⛔ Files ignored due to path filters (15)
  • bindings/go/constructor/go.sum is excluded by !**/*.sum
  • bindings/go/helm/go.sum is excluded by !**/*.sum
  • bindings/go/input/dir/go.sum is excluded by !**/*.sum
  • bindings/go/input/file/go.sum is excluded by !**/*.sum
  • bindings/go/input/utf8/go.sum is excluded by !**/*.sum
  • bindings/go/oci/go.sum is excluded by !**/*.sum
  • bindings/go/oci/integration/go.sum is excluded by !**/*.sum
  • bindings/go/plugin/go.sum is excluded by !**/*.sum
  • bindings/go/repository/go.sum is excluded by !**/*.sum
  • bindings/go/transfer/go.sum is excluded by !**/*.sum
  • bindings/go/transfer/integration/go.sum is excluded by !**/*.sum
  • bindings/go/transform/go.sum is excluded by !**/*.sum
  • cli/go.sum is excluded by !**/*.sum
  • cli/integration/go.sum is excluded by !**/*.sum
  • kubernetes/controller/go.sum is excluded by !**/*.sum
📒 Files selected for processing (34)
  • bindings/go/constructor/construct.go
  • bindings/go/constructor/construct_resource_test.go
  • bindings/go/constructor/go.mod
  • bindings/go/helm/go.mod
  • bindings/go/helm/transformation/get_helm_chart.go
  • bindings/go/input/dir/go.mod
  • bindings/go/input/file/go.mod
  • bindings/go/input/utf8/go.mod
  • bindings/go/oci/go.mod
  • bindings/go/oci/integration/go.mod
  • bindings/go/oci/transformer/add_component_version.go
  • bindings/go/oci/transformer/add_local_resource.go
  • bindings/go/oci/transformer/add_oci_artifact.go
  • bindings/go/oci/transformer/add_oci_artifact_test.go
  • bindings/go/oci/transformer/get_component_version.go
  • bindings/go/oci/transformer/get_local_resource.go
  • bindings/go/oci/transformer/get_oci_artifact.go
  • bindings/go/plugin/go.mod
  • bindings/go/repository/component/fallback/v1/repository.go
  • bindings/go/repository/component/resolvers/pathmatcher.go
  • bindings/go/repository/go.mod
  • bindings/go/transfer/go.mod
  • bindings/go/transfer/integration/go.mod
  • bindings/go/transform/go.mod
  • cli/cmd/add/component-version/cmd.go
  • cli/cmd/download/shared/common.go
  • cli/cmd/sign/component-version/cmd.go
  • cli/cmd/verify/component-version/cmd.go
  • cli/go.mod
  • cli/integration/go.mod
  • kubernetes/controller/go.mod
  • kubernetes/controller/internal/controller/deployer/deployer_controller.go
  • kubernetes/controller/internal/ocm/resource.go
  • kubernetes/controller/pkg/configuration/config_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 6 minutes and 33 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added kind/bugfix Bug kind/dependency dependency update, etc. size/m Medium labels Apr 29, 2026
@frewilhelm
Merge branch 'main' into fix-2331-3
ceacfd8
@frewilhelm
disable linter
5ac20ee 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@matthiasbruns matthiasbruns merged commit bf0b7e5 into open-component-model:main Apr 29, 2026
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthiasbruns matthiasbruns matthiasbruns approved these changes

@morri-son morri-son morri-son approved these changes

Assignees

No one assigned

Labels

kind/bugfix Bug kind/dependency dependency update, etc. size/m Medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frewilhelm @matthiasbruns @morri-son