Skip to content

chore: add new default to Subscriber Channel Size#2367

Merged
morri-son merged 1 commit into
open-component-model:mainfrom
morri-son:fix/conformance-flakiness-requeue-safety-net
Apr 22, 2026
Merged

chore: add new default to Subscriber Channel Size#2367
morri-son merged 1 commit into
open-component-model:mainfrom
morri-son:fix/conformance-flakiness-requeue-safety-net

Conversation

@morri-son

@morri-son morri-son commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Follow up of #2282, now using the possibility to configure the default and set it to 100.

@morrison-sap
add new default
ae92b98 
Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
@morri-son morri-son requested a review from a team as a code owner April 22, 2026 12:32
@morri-son morri-son added the kind/chore chore, maintenance, etc. label Apr 22, 2026
@netlify

netlify Bot commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for ocm-website canceled.

Name Link
🔨 Latest commit ae92b98
🔍 Latest deploy log https://app.netlify.com/projects/ocm-website/deploys/69e8bff54672ac0008351314

@coderabbitai

coderabbitai Bot commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7acda5d7-06f9-4c93-9e66-6f2c1f5752c1

📥 Commits

Reviewing files that changed from the base of the PR and between da65ced and ae92b98.

📒 Files selected for processing (5)
  • kubernetes/controller/chart/README.md
  • kubernetes/controller/chart/values.yaml
  • kubernetes/controller/cmd/main.go
  • kubernetes/controller/internal/resolution/workerpool/workerpool.go
  • kubernetes/controller/internal/resolution/workerpool/workerpool_test.go
📝 Walkthrough

Walkthrough

The default value of the resolver subscriber buffer size parameter is increased from 10 to 100 across multiple layers of the Kubernetes controller codebase: Helm chart documentation, chart values, CLI flag defaults, workerpool initialization logic, and corresponding tests.

Changes

Cohort / File(s) Summary
Helm Chart Configuration
kubernetes/controller/chart/README.md, kubernetes/controller/chart/values.yaml		 Updated documented and configured default value for manager.resolver.subscriberBufferSize from 10 to 100.
CLI Flag Default
kubernetes/controller/cmd/main.go		 Changed CLI flag resolver-subscriber-buffer-size default value from 10 to 100.
Workerpool Logic
kubernetes/controller/internal/resolution/workerpool/workerpool.go		 Increased default SubscriberBufferSize fallback in NewWorkerPool() from 10 to 100 when unspecified or invalid.
Unit Tests
kubernetes/controller/internal/resolution/workerpool/workerpool_test.go		 Updated test assertions in TestWorkerPool_SubscriberBufferSize to expect buffer capacity of 100 for default cases instead of 10.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

size/s

Suggested reviewers

  • matthiasbruns
  • jakobmoellerdev
  • Skarlso
  • frewilhelm

Poem

🐰 A buffer grows from ten to one-oh-oh,
More room for subscribers down below,
The resolver hops with newfound cheer,
No more queues to shed a tear! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: increasing the default Subscriber Channel Size from 10 to 100 across multiple files.
Description check ✅ Passed The description is related to the changeset, clearly identifying it as a follow-up to PR #2282 that configures the Subscriber Channel Size default to 100.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/s Small label Apr 22, 2026
@morri-son morri-son enabled auto-merge (squash) April 22, 2026 12:36
@morri-son morri-son merged commit fcfce1e into open-component-model:main Apr 22, 2026
27 of 28 checks passed
@morri-son morri-son deleted the fix/conformance-flakiness-requeue-safety-net branch April 23, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthiasbruns matthiasbruns matthiasbruns approved these changes

@frewilhelm frewilhelm frewilhelm approved these changes

Assignees

No one assigned

Labels

kind/chore chore, maintenance, etc. size/s Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morri-son @matthiasbruns @frewilhelm @morrison-sap