fix(GHA): use inputs.ref for publish eligibility in cli.yml#2299
Merged
morri-son merged 2 commits intoApr 15, 2026
Merged
Conversation
When cli-release.yml calls cli.yml via workflow_call, GITHUB_REF_NAME inherits the caller's ref (releases/v0.4) instead of the RC tag (cli/v0.4.0-rc.1). The branch-check only allowed publishing for main or cli/v* refs, so releases dispatched from release branches skipped the Publish and Attest job entirely. Use inputs.ref (the RC tag passed by cli-release.yml) when available, falling back to GITHUB_REF_NAME for direct push/tag triggers. Also update RELEASE_PROCESS.md to replace the removed "Branch to release from" input reference with "Use workflow from" branch selector. Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
Add comments explaining the dispatch model and github.ref_name behavior across the cli-release.yml → cli.yml workflow_call boundary. Key documentation: - cli-release.yml: operator must select releases/v* in "Use workflow from" - cli-release.yml build job: inputs.ref carries the RC tag, not the branch - cli.yml top: dual-role (CI + reusable) and ref inheritance caveat - cli.yml branch-check: publish eligibility table for all trigger scenarios Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jakobmoellerdev
approved these changes
Apr 15, 2026
99c44b5
into
open-component-model:releases/v0.4
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #2297 to
releases/v0.4.cli.ymlto useinputs.ref(RC tag) instead ofGITHUB_REF_NAME(branch) forworkflow_calltriggersworkflow_callref inheritance behavior across release workflows