feat(controller): move configuration from internal to pkg#2281
Merged
jakobmoellerdev merged 6 commits intoApr 14, 2026
Merged
Conversation
…mption Move internal/configuration to pkg/configuration to make the configuration loading API available to external consumers. Add package documentation with an API stability disclaimer. Update all internal import paths accordingly. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
✅ Deploy Preview for ocm-website canceled.
|
Contributor
📝 WalkthroughWalkthroughThis PR migrates the controller's configuration package from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
matthiasbruns
previously approved these changes
Apr 14, 2026
Co-authored-by: Matthias Bruns <github@matthiasbruns.com> Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@kubernetes/controller/pkg/configuration/doc.go`:
- Around line 4-9: The package comment in
kubernetes/controller/pkg/configuration/doc.go currently has an incomplete
sentence ending with “credentials and” before the bullet list; update the
package-level GoDoc so the sentence is complete and grammatically correct (e.g.,
remove the trailing "and" or merge that clause into the bullet intro),
preserving the existing bullets that describe behavior (flattening into
Configuration, calculating a hash, enforcing the allowlist) and referencing the
Configuration type in the text where appropriate; ensure the comment reads as a
single coherent paragraph before the list to satisfy GoDoc conventions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 994209b9-cb81-416b-a1e5-5c47d098badd
📒 Files selected for processing (13)
kubernetes/controller/Dockerfilekubernetes/controller/internal/controller/component/component_controller.gokubernetes/controller/internal/controller/deployer/deployer_controller.gokubernetes/controller/internal/controller/repository/repository_controller.gokubernetes/controller/internal/controller/resource/resource_controller.gokubernetes/controller/internal/ocm/resource.gokubernetes/controller/internal/resolution/cached_repository.gokubernetes/controller/internal/resolution/service.gokubernetes/controller/internal/resolution/service_test.gokubernetes/controller/internal/setup/integration_test.gokubernetes/controller/pkg/configuration/config.gokubernetes/controller/pkg/configuration/config_test.gokubernetes/controller/pkg/configuration/doc.go
💤 Files with no reviewable changes (1)
- kubernetes/controller/pkg/configuration/config.go
matthiasbruns
approved these changes
Apr 14, 2026
jakobmoellerdev
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Move internal/configuration to pkg/configuration to make the
configuration loading API available to external consumers. Add package
documentation with an API stability disclaimer. Update all internal
import paths accordingly.
Which issue(s) this PR fixes
Testing
How to test the changes
Verification
ocm