bindings/go/ctf/index/v1/index.go (1)

101-117: Consider removing stale pre-retag mutation logic in bindings/go/oci/ctf/store.go.

Now that AddArtifact owns retag resolution, the loop in addOrUpdateArtifactMetadataInIndex that mutates idx.GetArtifacts() (a clone) is misleading and has no effect. Simplifying that helper to delegate directly to idx.AddArtifact(meta) would reduce confusion.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@bindings/go/ctf/index/v1/index.go` around lines 101 - 117, The loop in
addOrUpdateArtifactMetadataInIndex that mutates a cloned slice via
idx.GetArtifacts() is stale and redundant because AddArtifact now handles retag
resolution; remove the mutation/retag loop and replace the helper logic to
simply call idx.AddArtifact(meta) (or i.AddArtifact(a)) and return, ensuring all
retagging and de-duplication is delegated to the existing AddArtifact
implementation.

bindings/go/ctf/index/v1/index_test.go (1)

157-190: Optional: strengthen duplicate subtests with content assertions.

Both subtests currently assert only length. Adding checks for repository/tag/digest equality would better catch accidental mutation paths while still keeping the tests lightweight.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@bindings/go/ctf/index/v1/index_test.go` around lines 157 - 190, Add
assertions in the "tagged duplicate" and "untagged duplicate" subtests to verify
that the retained artifact's fields match the original ArtifactMetadata (use the
local variable a) to catch accidental mutations: after obtaining arts :=
idx.GetArtifacts(), assert arts[0].Repository == a.Repository, arts[0].Tag ==
a.Tag, and arts[0].Digest == a.Digest (and keep the existing length checks);
reference NewIndex, ArtifactMetadata, AddArtifact, and GetArtifacts to locate
the test code to update.

bindings/go/ctf/index/v1/index.go (1)

101-110: Consider simplifying addOrUpdateArtifactMetadataInIndex in store.go.

The helper function in bindings/go/oci/ctf/store.go:385-400 attempts to clear tags on a cloned artifacts array, but GetArtifacts() returns a snapshot via slices.Clone(), so these modifications never persist to the index. With AddArtifact now handling the "retag" scenario internally (removing old entries with same repo+tag but different digest), the helper's tag-clearing logic is dead code. Simplify it to call idx.AddArtifact(meta) directly.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@bindings/go/ctf/index/v1/index.go` around lines 101 - 110, The helper
addOrUpdateArtifactMetadataInIndex in bindings/go/oci/ctf/store.go is performing
dead work by mutating a cloned slice from GetArtifacts() to clear tags; because
GetArtifacts() returns a snapshot (slices.Clone()) and AddArtifact already
handles the "retag" case (removing prior repo+tag entries), remove the
tag-clearing loop and simply invoke idx.AddArtifact(meta) to update the index;
update references to the cloned artifacts slice accordingly and delete the
obsolete mutation logic so the function directly delegates to AddArtifact.

bindings/go/ctf/index/v1/index.go (1)

111-118: MediaType is not preserved when retagging an untagged entry.

When an untagged entry is retagged (line 115), only the Tag field is updated. If the incoming ArtifactMetadata has a MediaType but the existing untagged entry does not (or vice versa), the incoming MediaType is silently discarded.

Consider whether MediaType should also be updated:

♻️ Optional fix to preserve MediaType

 		for idx, art := range i.Artifacts {
 			if art.Repository == a.Repository && art.Tag == "" && art.Digest == a.Digest {
 				i.Artifacts[idx].Tag = a.Tag
+				if a.MediaType != "" {
+					i.Artifacts[idx].MediaType = a.MediaType
+				}
 				return
 			}
 		}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@bindings/go/ctf/index/v1/index.go` around lines 111 - 118, The loop in
Index.Artifacts that retags an existing untagged entry (in function/method
handling ArtifactMetadata where i.Artifacts[idx].Tag = a.Tag) currently only
updates Tag and thereby discards incoming MediaType; update that branch to also
preserve MediaType by setting i.Artifacts[idx].MediaType = a.MediaType (or if
you prefer not to overwrite existing non-empty values, set it only when
i.Artifacts[idx].MediaType == "" and a.MediaType != ""), ensuring the
ArtifactMetadata fields are consistent when retagging.