Skip to content

chore: update resource API in conformance tests#2117

Merged
frewilhelm merged 3 commits into
open-component-model:mainfrom
frewilhelm:fix-conformance-test
Mar 30, 2026
Merged

chore: update resource API in conformance tests#2117
frewilhelm merged 3 commits into
open-component-model:mainfrom
frewilhelm:fix-conformance-test

Conversation

@frewilhelm

@frewilhelm frewilhelm commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Update the resource API in the conformance tests

Which issue(s) this PR fixes

Follow up for #2116

@frewilhelm
update resource API
2d2dda1 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm frewilhelm requested a review from a team as a code owner March 30, 2026 08:39
@coderabbitai

coderabbitai Bot commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Removes explicit interval field declarations from YAML resource manifests across two files in the conformance/scenarios/sovereign directory. The PostgreSQL, notes, and resource definitions no longer specify interval timing constraints. No functional logic or behavior changes.

Changes

Cohort / File(s) Summary
Resource interval field cleanup
conformance/scenarios/sovereign/components/product/deploy/rgd.yaml		 Removed interval: 1m from rgdResource wrapper and interval: 10m from postgresChartResource, postgresImageResource, notesChartResource, and notesImageResource resource definitions.
Resource interval field cleanup
conformance/scenarios/sovereign/deploy/bootstrap.yaml		 Removed interval: 1m from the sovereign-product-resource-rgd Resource spec.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

size/s

Suggested reviewers

  • morri-son
  • matthiasbruns
  • fabianburth

Poem

🐰 With whiskers twitched and paws so quick,
I hopped through YAML, field by field so thick,
Those intervals? Gone like morning dew,
Cleaner manifests—a rabbit's debut! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing interval fields from resource definitions in conformance tests to update the resource API.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description is related to the changeset, describing updates to the resource API in conformance tests and referencing a follow-up PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added kind/chore chore, maintenance, etc. size/xs Extra small labels Mar 30, 2026
@frewilhelm frewilhelm enabled auto-merge (squash) March 30, 2026 08:47
@frewilhelm frewilhelm merged commit 5910358 into open-component-model:main Mar 30, 2026
17 checks passed
@frewilhelm frewilhelm deleted the fix-conformance-test branch March 30, 2026 11:53
@morri-son morri-son mentioned this pull request Apr 14, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skarlso Skarlso Skarlso approved these changes

@matthiasbruns matthiasbruns matthiasbruns approved these changes

@fabianburth fabianburth fabianburth approved these changes

@jakobmoellerdev jakobmoellerdev jakobmoellerdev approved these changes

Assignees

No one assigned

Labels

kind/chore chore, maintenance, etc. size/xs Extra small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@frewilhelm @Skarlso @matthiasbruns @fabianburth @jakobmoellerdev