feat: DAG Library used by KRO adopted for OCM#21
Merged
Conversation
We want to use the KRO Graph Modelling Feature for Dependency Modelling while transferring resources. For this we are copying and adapting KROs take on Resource Graphs with a few adjustments: 1. We introduce generic capability to make the graphs work with anything in cmp.Ordered 2. We introduce InDegree/OutDegree to be able to selectively traverse the graph, by processing a graph through the indegree/outdegree.
frewilhelm
reviewed
Mar 18, 2025
| expected := strings.Split(g.Want, ",") | ||
| r.ElementsMatch(order, expected, "unexpected result from TopologicalSort for nodes=%q edges=%q, got %q, want %q", g.Nodes, g.Edges, order, expected) | ||
|
|
||
| // checkValidTopologicalOrder(t, d, order) |
Contributor
There was a problem hiding this comment.
What about this out-commented function?
Member
Author
There was a problem hiding this comment.
We do not have natural ordering in our graphs, so I excluded natural order processing. I will remove this leftover :)
frewilhelm
reviewed
Mar 18, 2025
Skarlso
reviewed
Mar 18, 2025
Skarlso
reviewed
Mar 18, 2025
Skarlso
reviewed
Mar 18, 2025
Skarlso
reviewed
Mar 18, 2025
# Conflicts: # REUSE.toml # Taskfile.yml
Closed
# Conflicts: # Taskfile.yml
Skarlso
approved these changes
Apr 14, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to use the KRO Graph Modelling Feature for Dependency Modelling while transferring resources. For this we are copying and adapting KROs take on Resource Graphs with a few adjustments:
What this PR does / why we need it
This is in preparation for our transfer library, which will need the directed acyclic graph capabilities for proper dependency management and ordering
Which issue(s) this PR fixes