feat: rename ocm-resource-repository subsystem to access in describe types#2083
Merged
jakobmoellerdev merged 2 commits intoMar 27, 2026
Conversation
…types Renames the subsystem from "ocm-resource-repository" to "access" with a description that reflects access methods rather than repositories. Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
Contributor
📝 WalkthroughWalkthroughA consistent subsystem renaming across the codebase, changing the identifier from "ocm-resource-repository" to "access" along with updated descriptions. Changes propagate through command help text, tests, documentation, and core subsystem registration without altering underlying functionality. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
cli/internal/subsystem/core.go (1)
23-26: Consider renaming the variable for clarity.The variable
ocmResourceRepositorynow creates a subsystem named"access", which is misleading. Consider renaming it toaccessSubsystemor justaccessto match the subsystem name.♻️ Proposed refactor
- ocmResourceRepository := NewSubsystem( + access := NewSubsystem( "access", "Access methods define how OCM resources are accessed and retrieved from their origin.", )Then update all references to
ocmResourceRepositoryin this file (lines 44, 55) to useaccess.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cli/internal/subsystem/core.go` around lines 23 - 26, The variable name ocmResourceRepository is misleading because it constructs NewSubsystem("access", ...); rename ocmResourceRepository to access (or accessSubsystem) and update all references in this file to the new identifier; specifically change the declaration that calls NewSubsystem("access", "Access methods...") and replace subsequent uses of ocmResourceRepository (e.g., where it’s passed/registered) with access to keep the name consistent with the subsystem.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@cli/internal/subsystem/core.go`:
- Around line 23-26: The variable name ocmResourceRepository is misleading
because it constructs NewSubsystem("access", ...); rename ocmResourceRepository
to access (or accessSubsystem) and update all references in this file to the new
identifier; specifically change the declaration that calls
NewSubsystem("access", "Access methods...") and replace subsequent uses of
ocmResourceRepository (e.g., where it’s passed/registered) with access to keep
the name consistent with the subsystem.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 01daa515-7eeb-4c1f-a5df-bf5a99885c23
📒 Files selected for processing (5)
cli/cmd/describe/types/cmd.gocli/cmd/describe/types/cmd_test.gocli/docs/reference/ocm_describe_types.mdcli/docs/reference/ocm_get_types.mdcli/internal/subsystem/core.go
matthiasbruns
approved these changes
Mar 27, 2026
morri-son
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Renames the subsystem from "ocm-resource-repository" to "access" with a description that reflects access methods rather than repositories.
Which issue(s) this PR fixes
fixes up the weirdly named type subsystem for resource accesses
Testing
Verification
ocm