fix: oci upload behavior#1806
Merged
matthiasbruns merged 13 commits intoFeb 20, 2026
Merged
Conversation
9ca520c to
beeb972
Compare
…r oci Signed-off-by: Fabian Burth <fabian.burth@sap.com>
beeb972 to
f2450a2
Compare
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
# Conflicts: # cli/cmd/transfer/component-version/internal/oci.go
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Contributor
|
I feel that we start getting into an if-else condition hell and it's worth exploring open-component-model/ocm-project#903 in the next sprints. |
matthiasbruns
approved these changes
Feb 20, 2026
Contributor
|
i just tested it locally, lgtm |
piotrjanik
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The behaviour for
localblobs:
oci-uploadset AND target ocm repo is oci AND localblob is oci artifact (media type) --> upload as ociociArtifacts:
oci-uploadset AND target ocm repo is oci --> upload as ociWhich issue(s) this PR fixes
Contributes: open-component-model/ocm-project#796